feat(desktop): flag already-installed themes in the install pickers - #55410
Merged
Conversation
The Cmd-K "Install theme…" palette listed Marketplace themes with no hint that you already had them, and clicking one re-downloaded + re-installed a theme you owned. The Appearance settings grid already detected this, but by parsing theme descriptions inline on every render — plumbing that never made it to the palette. Lift it into one reactive source and reuse it everywhere: - $marketplaceInstalls (computed over $userThemes): extensionId -> installed theme, derived once via marketplaceIdOf and memoized, instead of rebuilding a Set per render. - Both install surfaces now mark owned rows installed and, on click, re-activate the installed theme rather than re-fetching it. - Drops the duplicated description-parsing in settings and the per-session "installed here" state in both surfaces (the store is the source of truth, so previously-installed themes show correctly too).
OutThisLife
enabled auto-merge
June 30, 2026 04:30
1 task
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…eme-dedupe feat(desktop): flag already-installed themes in the install pickers
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…eme-dedupe feat(desktop): flag already-installed themes in the install pickers
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…eme-dedupe feat(desktop): flag already-installed themes in the install pickers
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…eme-dedupe feat(desktop): flag already-installed themes in the install pickers
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…eme-dedupe feat(desktop): flag already-installed themes in the install pickers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Going to Cmd-K → "Install theme…" listed VS Code Marketplace themes with no indication you already had them, and clicking one re-downloaded + re-installed a theme you already owned. The Appearance settings grid already detected installed themes — but by parsing theme descriptions inline on every render, plumbing that never reached the palette.
This lifts that detection into one reactive source and reuses it on both surfaces:
$marketplaceInstalls(computedover$userThemes):extensionId → installed theme, derived once viamarketplaceIdOfand memoized — instead of rebuilding aSeton every render.Why this shape
themes/user-themes.ts(where installed themes already live) replaces two ad-hoc derivations.computedrecomputes only when$userThemeschanges, vs. a freshSet/parse per render; clicking an installed theme is now a store lookup + activate instead of a network download + unzip + convert.Files
themes/user-themes.ts—marketplaceIdOf()+$marketplaceInstallsselector.app/command-palette/marketplace-theme-page.tsx— mark installed; activate-on-click.app/settings/appearance-settings.tsx— consume the shared selector; drop inline parsing + session state.themes/user-themes.test.ts— coverage for the new selector.Test plan
vitest run --environment jsdom themes/user-themes.test.ts— 9 passedtsc -p . --noEmit— cleaneslinton all touched files — clean