Skip to content

fix(desktop): handle stale backend when creating projects (#54999) - #55331

Merged
OutThisLife merged 2 commits into
NousResearch:mainfrom
xxxigm:fix/desktop-projects-stale-backend
Jun 30, 2026
Merged

fix(desktop): handle stale backend when creating projects (#54999)#55331
OutThisLife merged 2 commits into
NousResearch:mainfrom
xxxigm:fix/desktop-projects-stale-backend

Conversation

@xxxigm

@xxxigm xxxigm commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Detect when the connected backend predates the projects.* JSON-RPC surface (same 0.17.0 label, older install).
  • Replace the raw unknown method: projects.create toast with a clear “update your backend” message.
  • Block the New project dialog once the backend is known stale.

Root cause

Desktop 0.17.0 ships the Projects UI, but backends installed from the June 19 release also report 0.17.0 without projects.create.

Fixes #54999

Test plan

  • npm run test:ui -- src/lib/gateway-rpc.test.ts src/store/projects.test.ts
  • Fresh desktop install with an outdated backend → friendly warning instead of cryptic RPC error
  • After backend update → project creation works

@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jun 30, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Handles stale backend gracefully when creating projects. Clean with tests.

@tonydwb

tonydwb commented Jun 30, 2026

Copy link
Copy Markdown

Code Review Summary

Verdict: Approved

Detects when the connected backend predates the projects.* JSON-RPC surface and shows a friendly error message instead of failing silently. The detection is based on method-not-found errors from JSON-RPC calls.

✅ Looks Good

  • Clean detection via isMissingRpcMethod helper
  • Friendly user-facing error with actionable guidance
  • Properly blocks create dialog when backend is known stale
  • Good test coverage: missing method detection, stale backend error, dialog blocking
  • i18n-ready with translation key

Reviewed by Hermes Agent

xxxigm added 2 commits June 30, 2026 21:23
Regression tests for stale-backend detection when projects.create is
missing from an older backend that still reports the same semver.
Probe the projects.* RPC surface, block create with a clear update hint,
and avoid the raw "unknown method" toast. Includes i18n for en, zh, ja,
and zh-hant.

Fixes NousResearch#54999
@xxxigm
xxxigm force-pushed the fix/desktop-projects-stale-backend branch from f2eed1c to 83e10a6 Compare June 30, 2026 14:23
@OutThisLife
OutThisLife merged commit f99ba56 into NousResearch:main Jun 30, 2026
22 checks passed
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…s-stale-backend

fix(desktop): handle stale backend when creating projects (NousResearch#54999)
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
…s-stale-backend

fix(desktop): handle stale backend when creating projects (NousResearch#54999)
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…s-stale-backend

fix(desktop): handle stale backend when creating projects (NousResearch#54999)
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…s-stale-backend

fix(desktop): handle stale backend when creating projects (NousResearch#54999)
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…s-stale-backend

fix(desktop): handle stale backend when creating projects (NousResearch#54999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: unknown projects.create

4 participants