fix(stt): report unregistered configured providers - #55168
Closed
ooiuuii wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for isolating the diagnostic boundary. Current main still falls through from unsuccessful plugin resolution to the generic envelope at Problems
Suggested changes
Automated hermes-sweeper review. |
Contributor
|
Merged into main via consolidated salvage PR #73510 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider_not_registeredSTT error when an explicitstt.providername is not claimed by a built-in, command provider, or plugin providerNo STT provider availableguidance for auto-detect failures with no explicit providerFixes #55167.
Why
This mirrors the diagnostic boundary fixed in openclaw/openclaw#97484: when the user configured a concrete media/STT provider id, the error should preserve that id and point at the registration surface instead of falling through to generic setup advice.
Before this change,
stt.provider: openrouterwith no matching plugin and nostt.providers.openrouter.commandreturned only the genericNo STT provider availablemessage. That made the missing registration look like a local/Groq/OpenAI setup problem.Validation
python -m pytest tests\tools\test_transcription_plugin_dispatch.py -q->29 passedruff check tools\transcription_tools.py tests\tools\test_transcription_plugin_dispatch.py-> passedgit diff --check-> passedpython scripts\check-windows-footguns.py --diff origin/main-> passedAdditional adjacent check attempted:
python -m pytest tests\gateway\test_stt_config.py tests\tools\test_transcription_plugin_dispatch.py -q->34 passed, 2 failedtests/gateway/test_stt_config.py: the tests assert/tmp/voice.ogg, while the Windows run returnsC:\tmp\voice.ogg. They do not exercise the STT provider registration path changed here.No repository-local
autoreviewhelper was found; only standard scripts such asscripts/check-windows-footguns.pyare present.