fix(desktop): show Gateway statusbar tooltip via composed trigger Slots - #55086
Merged
Conversation
The Gateway item is the only statusbar entry with variant === 'menu'. Since da73223 wrapped every render branch in `Tip`, the menu branch nested `<DropdownMenu>` (a Radix Root that renders no DOM node) inside `Tip`'s `<TooltipTrigger asChild>`. With no element to attach to, Radix could never wire hover listeners, so the tooltip silently never showed. `Tip` also can't be moved inside `DropdownMenuTrigger asChild` (the shape proposed in #54859): it's a plain component, not a Slot-forwarding one, so the trigger's injected ref/handlers would land on `TooltipContent` instead of the button and break the menu's click + popper anchoring. Fix by composing both trigger Slots directly onto a single <button> (`TooltipTrigger asChild` over `DropdownMenuTrigger asChild`), the pattern already used in profile-switcher.tsx, and skip the tooltip wrapper entirely when the item has no title. Supersedes #54859. Co-authored-by: wnuuee1 <wnuuee1@users.noreply.github.com>
OutThisLife
enabled auto-merge
June 29, 2026 18:50
alt-glitch
added
type/bug
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…tatusbar-tooltip fix(desktop): show Gateway statusbar tooltip via composed trigger Slots
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…tatusbar-tooltip fix(desktop): show Gateway statusbar tooltip via composed trigger Slots
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…tatusbar-tooltip fix(desktop): show Gateway statusbar tooltip via composed trigger Slots
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…tatusbar-tooltip fix(desktop): show Gateway statusbar tooltip via composed trigger Slots
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…tatusbar-tooltip fix(desktop): show Gateway statusbar tooltip via composed trigger Slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variant === 'menu'. Since da73223 wrapped every render branch inTip, the menu branch nested<DropdownMenu>(a RadixRootthat renders no DOM node) insideTip's<TooltipTrigger asChild>, so Radix had nothing to attach hover listeners to and the tooltip silently never showed.<button>(TooltipTrigger asChildoverDropdownMenuTrigger asChild) — the pattern already used inapps/desktop/src/app/chat/sidebar/profile-switcher.tsx— and skipping the tooltip wrapper entirely when an item has notitle.<Tip>inside<DropdownMenuTrigger asChild>; becauseTipis a plain component (not Slot-forwarding), the trigger's injected ref/handlers would land onTooltipContentinstead of the button, breaking the menu's open-on-click and popper anchoring. Original author credited viaCo-authored-by.Test plan
npx tsc --noEmit(apps/desktop) — cleannpx eslint src/app/shell/statusbar-controls.tsx— clean