Refactor: Shrink the core toolset array (Fixes #54963) - #54995
Refactor: Shrink the core toolset array (Fixes #54963)#54995aniruddhaadak80 wants to merge 16 commits into
Conversation
Related: implements #54963, and overlaps open PR #45847 (which also narrows |
c9829c2 to
9fc6c92
Compare
…and stabilize Windows test suite
…r tilde test on Windows
… in skill commands
…and symlink privilege errors
…ad verifier methods, fix Windows path test)
9fc6c92 to
6101316
Compare
teknium1
left a comment
There was a problem hiding this comment.
Thanks for pursuing the narrow-core goal; the current main still has the cited peripheral schemas in toolsets.py:66-79.
Problems
- The branch has unresolved conflict markers in
run_agent.py:204-209(inside an import block), plustests/hermes_cli/test_model_switch_custom_providers.py:1209,1370. This leaves the production module unparsable. - The 100%-similarity rename from
tools/homeassistant_tool.pytoplugins/homeassistant/__init__.pydoes not make Home Assistant loadable. Builtin discovery only imports eligibletools/*.pymodules (tools/registry.py:58-75), while directory plugins requireplugin.yamlandregister(ctx)(hermes_cli/plugins.py:19-20). The PR tree contains no Home Assistant manifest. - This would remove the registrations relied on by the existing
HASS_TOKENauto-enable path for CLI and cron (hermes_cli/tools_config.py:1767-1775).
Suggested changes
- Resolve the conflict markers and isolate the
toolsets.pyreduction from the unrelated 60-file changes. - Keep HA builtin registration for now, or implement a complete manifest-backed plugin registration path and verify CLI/cron HA resolution.
This is an automated hermes-sweeper review.
| _is_multimodal_tool_result, | ||
| _multimodal_text_summary, | ||
| _append_subdir_hint_to_multimodal, # noqa: F401 # re-exported for tests that `from run_agent import _append_subdir_hint_to_multimodal` | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Blocking: this unresolved merge-conflict marker is inside the import block. run_agent.py cannot be parsed until the <<<<<<</=======/>>>>>>> sequence is resolved.
|
Closing as superseded — the reviewable pieces of this broad stabilization bundle have been rebuilt as focused PRs against current
The remaining ~60-file bulk of this branch predates thousands of upstream commits (api_server alone differs by >4000 lines) and can no longer be verified or merged safely — a squash would silently revert current |
Description
This PR addresses issue #54963. It shrinks the _HERMES_CORE_TOOLS list by removing non-essential capabilities (like homeassistant, kanban, cron, image generation, and computer use) so they don't consume context window tokens on every model API call.
We also physically move ools/homeassistant_tool.py to plugins/homeassistant/init.py as a starting point for migrating these to runtime-discovered plugins.
Testing