Skip to content

fix(dashboard-auth): skip auto-SSO redirect for password-only providers #54884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjfkai wants to merge 1 commit into from
Closed

fix(dashboard-auth): skip auto-SSO redirect for password-only providers #54884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hermes_cli/dashboard_auth/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,16 @@ def _auto_sso_response(request: Request) -> Response | None:
# Zero → nothing to redirect to. Two+ → user must choose at /login.
return None

provider = providers[0]

# Password-only providers (e.g. BasicAuthProvider) don't support the
# OAuth redirect dance that /auth/login initiates. Fall through to
# the normal /login interstitial which renders a password form.
if getattr(provider, "supports_password", False):
return None

from hermes_cli.dashboard_auth.prefix import prefix_from_request

provider = providers[0]
prefix = prefix_from_request(request)
next_param = _safe_next_target(request)
from urllib.parse import quote
Expand Down