Skip to content

feat(webhook): verify native Asana webhook signatures (X-Hook-Signature) #54697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mguttmann wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

feat(webhook): verify native Asana webhook signatures (X-Hook-Signature) #54697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions gateway/platforms/webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,15 @@ def _header(name: str) -> str:
).hexdigest()
return hmac.compare_digest(generic_sig, expected)

# Asana: X-Hook-Signature = <hex HMAC-SHA256 of raw body>
# Secret is established during the Asana webhook handshake (X-Hook-Secret).
asana_sig = request.headers.get("X-Hook-Signature", "")
if asana_sig:
expected = hmac.new(
secret.encode(), body, hashlib.sha256
).hexdigest()
return hmac.compare_digest(asana_sig, expected)

# No recognised signature header but secret is configured → reject
logger.debug(
"[webhook] Secret configured but no signature header found"
Expand Down