Skip to content

fix(cli): skip expensive model warning for custom providers (Fixes #54348) #54536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
+8 −0
Closed

fix(cli): skip expensive model warning for custom providers (Fixes #54348) #54536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hermes_cli/model_cost_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ def expensive_model_warning(
if not model:
return None

# Custom providers (custom:xxx) use their own pricing that differs from
# the models.dev catalog (which stores OpenRouter prices). Triggering
# the expensive-model warning on inaccurate catalog data blocks model
# switching silently — skip the check entirely for custom providers.
# See #54348.
if provider and provider.startswith("custom:"):

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This excludes only named custom:<name> providers. The current switch path also deliberately supports the bare custom endpoint (hermes_cli/model_switch.py:1155,1208), so it can still reach this guard; include provider == "custom" as well.

return None

input_cost, output_cost, source = _pricing_from_model_info(model_info)
if input_cost is None and output_cost is None and provider:
try:
Expand Down