fix(moa): route xai-oauth references through direct credential path - #54501
Closed
Ne0teric wants to merge 1 commit into
Closed
fix(moa): route xai-oauth references through direct credential path#54501Ne0teric wants to merge 1 commit into
Ne0teric wants to merge 1 commit into
Conversation
The auxiliary_client.call_llm path used for MoA reference models does not support OAuth-backed providers. When xai-oauth is configured as a reference provider, call_llm silently fails and the Grok responses are dropped — the aggregator still returns results but the MoA pipeline is effectively single-model. Adds _call_reference_direct() which resolves xai-oauth credentials through resolve_runtime_provider() (the same JWT resolution the main model path uses) and creates a direct OpenAI client, bypassing call_llm entirely. Refs: NousResearch#53602 (prior art — same approach, adapted for refactored codebase)
Collaborator
Contributor
Author
|
Closing — superseded by auxiliary_client improvements. The code path ( → wrapper → branch for xai-oauth) now handles OAuth-backed credential resolution properly. Tested live: both grok-build-0.1 and grok-4.3 references respond correctly through the standard path without . The bypass approach is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
auxiliary_client.call_llmpath used for MoA reference models does not support OAuth-backed providers. Whenxai-oauthis configured as a reference provider, each call silently fails and the Grok responses are dropped. The aggregator still returns results, so the failure is invisible unless you checkagent.logfor warnings.Fix
Adds
_call_reference_direct()— resolves xai-oauth credentials throughresolve_runtime_provider()(the same JWT resolution the main model path uses) and creates a directOpenAIclient, bypassingcall_llmentirely.Only
xai-oauthis routed through the direct path. Other OAuth providers (nous,openai-codex) continue throughcall_llmas before.Testing