fix(browser): extend private-network guard to browser_console - #54477
fix(browser): extend private-network guard to browser_console#54477necoweb3 wants to merge 1 commit into
Conversation
|
looks mergeable I found no source-level blocker in the browser private-network guard change. The patch closes the The sensitive boundary is untrusted page console output and exception details after browser eval navigation to a private/internal URL; Signed: GPT-5.5-xhigh in Codex |
…NousResearch#54477) (#321) Co-authored-by: qbit-mirror-bot <qbit-mirror-bot@users.noreply.github.com>
Summary
This extends the browser private-network SSRF guard to
browser_console()when it is used in console-output mode.Why
Recent SSRF fixes sealed
browser_snapshot,browser_vision,_browser_eval, andbrowser_get_imagesagainst eval-navigated private pages. However,browser_console()has two modes:browser_console(expression=...)evaluates JavaScript and already routes through_browser_eval.browser_console()withoutexpressionfetches console logs and uncaught exceptions directly.The second path did not re-check the current page URL before returning console/error output. After an eval-driven navigation to a private/internal URL, this could expose console messages or exception details from the internal page.
Changes
_eval_ssrf_guard_active()+_current_page_private_url()check tobrowser_console()console-output mode.allow_private_urlsbypass.Tests