Conversation
Author
|
Closing this after rebasing against current main. Upstream has already removed the forced pytest-timeout signal method here, and current main now uses only the non-integration marker in addopts, so this branch is obsolete and would no longer be the right patch. Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pytest config forces
pytest-timeoutto use--timeout-method=signal. That method is POSIX-specific and is not available on Windows, so Windows contributors cannot run the test suite with the repository's default pytest config.Before / after
Before, running pytest on Windows with the configured timeout plugin failed because the
signaltimeout method is not supported.After, the config keeps the same
--timeout=30per-test cap but leaves the timeout method unset, allowingpytest-timeoutto choose its platform-safe default (signalon POSIX,threadon Windows).Verification
Ran locally on Windows:
uv run --extra dev pytest tests\test_base_url_hostname.py -qResult:
25 passed.Also ran: