Skip to content

fix(tests): use platform-safe timeout method - #54437

Closed
Ghraven wants to merge 1 commit into
NousResearch:mainfrom
Ghraven:fix-windows-pytest-timeout-method
Closed

Ghraven wants to merge 1 commit into
NousResearch:mainfrom
Ghraven:fix-windows-pytest-timeout-method

Conversation

@Ghraven

@Ghraven Ghraven commented Jun 28, 2026

Copy link
Copy Markdown

Problem

The pytest config forces pytest-timeout to use --timeout-method=signal. That method is POSIX-specific and is not available on Windows, so Windows contributors cannot run the test suite with the repository's default pytest config.

Before / after

Before, running pytest on Windows with the configured timeout plugin failed because the signal timeout method is not supported.

After, the config keeps the same --timeout=30 per-test cap but leaves the timeout method unset, allowing pytest-timeout to choose its platform-safe default (signal on POSIX, thread on Windows).

Verification

Ran locally on Windows:

uv run --extra dev pytest tests\test_base_url_hostname.py -q

Result: 25 passed.

Also ran:

git diff --check origin/main...HEAD

@Ghraven
Ghraven requested a review from a team June 28, 2026 21:11
@Ghraven

Ghraven commented Jun 28, 2026

Copy link
Copy Markdown
Author

Closing this after rebasing against current main. Upstream has already removed the forced pytest-timeout signal method here, and current main now uses only the non-integration marker in addopts, so this branch is obsolete and would no longer be the right patch. Thanks!

@Ghraven Ghraven closed this Jun 28, 2026
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/cli CLI entry point, hermes_cli/, setup wizard platform/windows Native Windows-specific behavior or breakage P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jun 28, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.
Duplicate of #39881 (merged 2026-06-09), which already removed --timeout-method=signal; current main carries the cross-platform fix. Same one-line pyproject change as the prior #43182/#40044. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have platform/windows Native Windows-specific behavior or breakage type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants