Add desktop Backdrop Opacity control - #54413
Closed
intellectronica wants to merge 4 commits into
Closed
intellectronica wants to merge 4 commits into
intellectronica wants to merge 4 commits into
Conversation
alt-glitch
added
type/feature
intellectronica
marked this pull request as ready for review
June 28, 2026 20:06
2 tasks
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the focused renderer-side control and persistence coverage.
Problems
apps/desktop/src/i18n/ja.ts:290-291,zh.ts:373-374, andzh-hant.ts:282-283add English text rather than localized strings. The Desktop guide requires all locales to be updated (apps/desktop/AGENTS.md:197-198).- Current main has since merged the binary backdrop toggle in #64598. Its render gate is now
on && statue.enabledatapps/desktop/src/components/Backdrop.tsx:94, and GitHub reports this PR as conflicting. Salvage should retain that gate and compose the opacity multiplier with the currentstatue.opacityvalue.
Suggested changes
- Supply translations for the three non-English locale entries.
- Resolve the #64598 overlap by keeping both the existing on/off toggle and this slider in Appearance.
Automated hermes-sweeper review.
| toolViewDesc: 'プロダクト表示は生のツールペイロードを隠し、テクニカル表示は入出力をすべて表示します。', | ||
| translucencyTitle: 'ウィンドウの透過', | ||
| translucencyDesc: 'ウィンドウ全体を透過させてデスクトップを表示します。macOS と Windows のみ。', | ||
| backdropOpacityTitle: 'Backdrop Opacity', |
Collaborator
There was a problem hiding this comment.
Please provide Japanese strings here (and translate the matching new zh.ts and zh-hant.ts entries). The Desktop guide requires all locales to be updated.
teknium1
added
sweeper:risk-compatibility
Contributor
Author
|
Not necessary with the new toggle. |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a desktop Appearance setting for Backdrop Opacity, placed directly under the existing Window Translucency control.
The new control is a 0-100% slider with a default of 100%. At 100%, Hermes keeps the backdrop image at its current visual strength; at 0%, the backdrop image becomes transparent. This only affects the renderer backdrop image layer in the main window and does not change native window opacity or the existing Window Translucency behaviour.
Details
backdrop-opacitypreference.Validation
npm --workspace apps/desktop run test:ui -- src/store/backdrop-opacity.test.tsnpm --workspace apps/desktop run typechecknpx eslint src/store/backdrop-opacity.ts src/store/backdrop-opacity.test.ts src/components/Backdrop.tsx src/app/settings/appearance-settings.tsx src/i18n/en.ts src/i18n/ja.ts src/i18n/types.ts src/i18n/zh.ts src/i18n/zh-hant.tsfromapps/desktopnpm --workspace apps/desktop run buildNote: full
npm --workspace apps/desktop run lintis currently blocked by pre-existing lint errors in untouched files (electron/titlebar-overlay-width.cjs) plus existing padding warnings elsewhere.