feat(desktop): add file-backed session pins bridge - #54299
Closed
rerdi92 wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for the persistence bridge work. The related pinned-session problem remains real on current main, but this patch does not yet make an externally restored aged pin display. Problems
Suggested changes
Automated hermes-sweeper review. |
Collaborator
|
Superseded by #74234, which makes pins server-owned so they survive paging and sync between apps. Your work is carried in it and you're credited as a co-author — thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fresh local verification was run on the PR-ready clean worktree and active local main.
Clean worktree (
C:/Users/82109/AppData/Local/hermes/worktrees/hq-upstream-verify-20260628-222651):python -m pytest tests/gateway/test_restart_drain.py -q -n 0→ 22 passed, 2 warningspython -m py_compile gateway/run.py tests/gateway/test_restart_drain.py→ passedgit diff --check origin/main..HEAD -- gateway/run.py tests/gateway/test_restart_drain.py→ passedgit diff --check origin/main..HEAD→ passedActive local main (
C:/Users/82109/AppData/Local/hermes/hermes-agent):python -m pytest tests/gateway/test_restart_drain.py -q -n 0→ 21 passed, 2 warningsnpm --workspace apps/desktop run test:ui -- src/store/session.test.ts src/store/layout.test.ts→ 23 passednpm --workspace apps/desktop run typecheck→ passedpython -m py_compile gateway/run.py gateway/session.py tests/gateway/test_restart_drain.py→ passednode --check apps/desktop/electron/main.cjs→ passednode --check apps/desktop/electron/preload.cjs→ passedgit diff --check/ conflict marker checks / added-line security scan → passedgit diff --check origin/main..HEAD→ passedNotes
This branch was built from a clean
origin/mainworktree and keeps the recovery stack separate from the divergent localmainstate.