fix(telegram): suppress quotes on internal status messages - #54274
Open
timsmykov wants to merge 1 commit into
Open
fix(telegram): suppress quotes on internal status messages#54274timsmykov wants to merge 1 commit into
timsmykov wants to merge 1 commit into
Conversation
tonydwb
reviewed
Jun 28, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: LGTM
Suppresses quote display on Telegram internal status messages by adding a telegram_reply_to_mode metadata field. The implementation is clean — the gateway sets 'off' mode on non-conversational sends, and the adapter respects it. Tests cover both the metadata propagation and the quote suppression.
Reviewed by Hermes Agent
Contributor
|
Thanks for the focused Telegram routing fix. The current-main premise is still valid: Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telegram_reply_to_mode=off.Why
Hermes-created Telegram DM topic lanes can require a reply anchor for routing, but internal progress/status messages should not render as visible replies quoting the user's prompt. This keeps topic delivery while removing repeated quote clutter.
Tests
python -m compileall -q plugins/platforms/telegram/adapter.py gateway/run.py tests/gateway/test_telegram_thread_fallback.py tests/gateway/test_run_progress_topics.pyruff check plugins/platforms/telegram/adapter.py gateway/run.py tests/gateway/test_telegram_thread_fallback.py tests/gateway/test_run_progress_topics.pypython -m pytest tests/gateway/test_telegram_thread_fallback.py tests/gateway/test_run_progress_topics.py -q -o 'addopts='git merge-treeagainstupstream/main: clean