Skip to content

fix: kill entire process tree on Windows to prevent GUI program hang (#54201) #54235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sahil-SS9 wants to merge 1 commit into from
Closed

fix: kill entire process tree on Windows to prevent GUI program hang (#54201) #54235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/terminal_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,8 @@ def _transform_sudo_command(command: str | None) -> tuple[str | None, str | None
PTY mode: Set pty=true for interactive CLI tools (Codex, Claude Code, Python REPL).

Do NOT use vim/nano/interactive tools without pty=true — they hang without a pseudo-terminal. Pipe git output to cat if it might page.

On Windows, launching GUI .exe programs directly in foreground mode will hang the session because the GUI process inherits the stdout pipe and never exits. Use `powershell -Command "Start-Process 'C:\\path\\to\\program.exe'"` instead — PowerShell exits immediately after launching the GUI program.
"""

# Global state for environment lifecycle management
Expand Down
Loading