fix(kanban): give each subtask its own worktree instead of inheriting parent path (#53983)

[liuhao1024]

What does this PR do?

Fixes concurrent subtask worktree collision in kanban's worktree workspace mode. When a parent task uses workspace_kind=worktree and spawns multiple child tasks, all children inherited the parent's workspace_path (its own .worktrees/{parent_task_id} directory) instead of getting their own. This caused file conflicts and git errors when concurrent workers operated in the same directory.

Related Issue

Fixes #53983

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

• tools/kanban_tools.py: Skip workspace_path inheritance when workspace_kind == "worktree". Each subtask now gets its own worktree derived from the project repo by create_task. Dir and scratch workspace inheritance remain unchanged.
• tests/tools/test_kanban_tools.py: Added test_create_worktree_subtask_gets_own_path — verifies a child task inheriting a worktree workspace gets a different path than the parent.

How to Test

1. python -m pytest tests/tools/test_kanban_tools.py -x -q — all 91 tests should pass
2. The new test test_create_worktree_subtask_gets_own_path directly verifies the fix: a child task inheriting workspace_kind=worktree from its parent must have a workspace_path that differs from the parent's.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS 26.4.1

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — or N/A
• I've updated cli-config.yaml.example if I added/changed config keys — or N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
• I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

The root cause is in tools/kanban_tools.py lines 820-826 (workspace inheritance). Before this fix, line 826 unconditionally copied the parent's workspace_path to the child. After the fix, worktree workspaces skip path inheritance so create_task in kanban_db.py derives a fresh .worktrees/{child-task-id} path.

[tonydwb]

Code Review Summary

Verdict: Comment — Clean fix

Small, focused fix that prevents kanban subtasks from inheriting the parent's worktree path. Each subtask now gets its own worktree directory to avoid concurrent worker collisions.

Changes:

• tools/kanban_tools.py: Adds a guard so worktree workspace types don't inherit workspace_path from the parent task. The child gets a fresh <repo>/.worktrees/<task-id> path via create_task.
• tests/tools/test_kanban_tools.py: New test verifying that worktree subtasks get their own path, not the parent's.

Assessment:

• Well-scoped: 2 files, 36 additions
• Test coverage for the specific scenario
• Comment explains the rationale clearly
• No security concerns

---

Reviewed by Hermes Agent

[tonydwb]

Code Review Summary

Verdict: Approved

Inlines local send attachments as data URIs for Signal RPC calls. When signal-cli runs in a separate container without shared filesystem access, raw file paths are not dereferenceable. The fix converts local file paths to data:mime;base64,... URIs at the RPC boundary, preserving already-inlined, remote, or missing attachments. Clean implementation with good test coverage for conversion, no-op cases, and RPC integration.

---

Reviewed by Hermes Agent

[teknium1]

Thanks for the focused collision fix. The current-head premise is real: tools/kanban_tools.py:905-913 copies the running worktree task's persisted concrete path, and hermes_cli/kanban_db.py:5709-5711 reuses an existing linked checkout.

Problems

• The proposed guard drops the repository anchor for unlinked worktree tasks. If the parent has no project_id and the board has no default_workdir, the child has no path; dispatch then raises at hermes_cli/kanban_db.py:5672-5699. Derive the parent repository root as the child anchor instead of dropping it.
• The added test (tests/tools/test_kanban_tools.py:807-826) uses a fake non-repository path and only checks inequality, so it accepts a null child path without proving a dispatchable distinct worktree.

Suggested changes

• Cover a real temporary git repository through dispatch and assert separate child/parent linked worktree paths and branches under the same repository.

Automated hermes-sweeper review.

[teknium1]

For an unlinked parent worktree, skipping inheritance leaves the child without a repository anchor. create_task can only derive a fresh path from a resolved project or board default; otherwise dispatch fails. Please derive and pass the parent repository root as the child anchor rather than dropping the path.

[teknium1]

Closing as superseded by #70143 (merged, SHA 781968b). Your PR was the earliest in this cluster to flag the workspace-inheritance bug (June 28) — thank you. The merged change removed the implicit literal-path inheritance in _handle_create entirely, so the worktree case you fixed (each subtask getting its own worktree instead of the parent's) is covered, along with the scratch and dir cases. The worktree-sibling half that lives in the decompose path (#53983 / #61911) is being addressed separately via a salvage of #61907.