fix: hide gh subprocess windows on Windows - #53961
Conversation
Canonical of the competing pair with #53962 (liuhao1024) — both fix #53957 at the same two |
06a2e47 to
e9f435b
Compare
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Broader version of #53962: applies windows_hide_flags() to both copilot_auth.py and doctor.py subprocess calls. The conditional if hide_flags: guard is correct (no-op on non-Windows). Both files get the same fix with a shared test. Well-scoped.
Reviewed by Hermes Agent
|
Closing as superseded by the consolidated Windows console-flash work tracked in #54220. The relevant pieces from this PR/cluster have now landed through the targeted follow-up PRs #54236, #53892, and #54417, or are recorded in the umbrella tracker for any remaining native-Windows verification. Keeping this separate PR open would duplicate the tracker and the merged follow-up work. Thanks for digging into this — the reports and PRs in this cluster helped identify the remaining spawn legs. |
Summary
gh auth tokenfor Copilot credentials.gh auth statusdoctor check.Problem
On Windows, Hermes Desktop could repeatedly spawn visible console windows while background credential resolution called the GitHub CLI. The short-lived
ghsubprocesses did not pass the hidden-window creation flag.Validation
Fixes #53957