feat(moa): render reference-model blocks in TUI and desktop, not just CLI by teknium1 · Pull Request #53855 · NousResearch/hermes-agent

teknium1 · 2026-06-27T23:00:06Z

Summary

Extends the MoA reference-block display from the CLI to the TUI (Ink) and desktop surfaces. When a MoA preset is the active model, each reference model's output now renders as a labelled thinking-style block — tagged with its source model, before the aggregator responds — on all three surfaces.

The facade already emits moa.reference / moa.aggregating through tool_progress_callback (shipped with the CLI work); this wires the TUI and desktop consumers off that same seam — no new plumbing.

Changes

tui_gateway/server.py: _on_tool_progress relays moa.reference (label / text / index / count) and moa.aggregating to the Ink/desktop client as their own events.
ui-tui: gatewayTypes adds the two event shapes; createGatewayEventHandler routes them; turnController.recordMoaReference pushes a committed thinking-style segment tagged with the source model. Shown regardless of showReasoning — references ARE the mixture-of-agents process the user opted into, not ordinary reasoning. moa.aggregating is a status-only transition (no transcript entry).
apps/desktop: use-message-stream appends each reference as a labelled reasoning chunk via the existing reasoning disclosure; GatewayEventPayload gains label / index / aggregator.

Validation

Surface	Render
CLI	labelled `┊ ◇ Reference i/n — <model>` thinking block (already shipped)
TUI (Ink)	committed segment, `◇ Reference i/n — <model>` + text, scrollable
Desktop	labelled chunk in the reasoning disclosure

TUI: createGatewayEventHandler.test.ts → 77 pass (3 new: render, showReasoning-independence, aggregating-no-segment). npm run typecheck + lint clean.
Desktop: typecheck + eslint clean on the changed files.
Python: tests/tui_gateway/test_moa_reference_emit.py → 3 pass (label/index relay, aggregating relay, index-omitted).

Infographic

github-actions · 2026-06-27T23:01:07Z

🔎 Lint report: `hermes/moa-reference-tui-desktop` vs `origin/main`

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11519 on HEAD, 11518 on base (🆕 +1)

🆕 New issues (1):

Rule	Count
`unresolved-import`	1

First entries

tests/tui_gateway/test_moa_reference_emit.py:14: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`

✅ Fixed issues: none

Unchanged: 6063 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

… CLI The MoA reference-block display (each reference model's output shown as a labelled thinking block before the aggregator responds) previously existed only in the classic CLI. The facade already emits moa.reference / moa.aggregating through tool_progress_callback; this wires the TUI and desktop consumers. - tui_gateway/server.py: _on_tool_progress relays moa.reference (label / text / index / count) and moa.aggregating to the Ink/desktop client as their own events. - ui-tui: gatewayTypes adds the two event shapes; createGatewayEventHandler routes them; turnController.recordMoaReference pushes a committed thinking-style segment tagged with the source model. Shown regardless of showReasoning — references ARE the mixture-of-agents process the user opted into, not ordinary reasoning. moa.aggregating is a status-only transition (no transcript entry). - apps/desktop: use-message-stream appends each reference as a labelled reasoning chunk via the existing reasoning disclosure; GatewayEventPayload gains label/index/aggregator. Tests: tui_gateway emit (3), Ink handler render + showReasoning-independence + aggregating-no-segment (3). TUI typecheck/lint clean; desktop typecheck/lint clean.

tonydwb

Code Review Summary

Verdict: Approved

MoA reference-model rendering in TUI and desktop (8 files). Well-scoped feature extension:

New moa.reference event type surfaces reference model output as labelled thinking chunks
Desktop hook (use-message-stream.ts) handles the new event with proper label formatting
Type definitions updated (GatewayEventPayload extended with label, index, aggregator)
New test test_moa_reference_emit.py with comprehensive mock setup
Pet activity state updated for reasoning indicators

Clean extension of existing MoA infrastructure. Good test coverage.

… CLI (NousResearch#53855) The MoA reference-block display (each reference model's output shown as a labelled thinking block before the aggregator responds) previously existed only in the classic CLI. The facade already emits moa.reference / moa.aggregating through tool_progress_callback; this wires the TUI and desktop consumers. - tui_gateway/server.py: _on_tool_progress relays moa.reference (label / text / index / count) and moa.aggregating to the Ink/desktop client as their own events. - ui-tui: gatewayTypes adds the two event shapes; createGatewayEventHandler routes them; turnController.recordMoaReference pushes a committed thinking-style segment tagged with the source model. Shown regardless of showReasoning — references ARE the mixture-of-agents process the user opted into, not ordinary reasoning. moa.aggregating is a status-only transition (no transcript entry). - apps/desktop: use-message-stream appends each reference as a labelled reasoning chunk via the existing reasoning disclosure; GatewayEventPayload gains label/index/aggregator. Tests: tui_gateway emit (3), Ink handler render + showReasoning-independence + aggregating-no-segment (3). TUI typecheck/lint clean; desktop typecheck/lint clean.

…placing Every moa.reference event called appendReasoningDelta(..., replace=true), which wipes ALL existing reasoning-type message parts and seeds exactly one new part. With two or more MoA reference models, each later reference erased the reasoning disclosure built by earlier references, so only the last advisor's output ever stayed visible instead of one labelled block per reference (contradicting the multi-reference visibility behavior from #53855). Only the first reference (index <= 1, or missing) now replaces — preserving the original "clear stale reasoning from before this turn" behavior. Every later reference accumulates via the existing queue-then-flush path instead, applied immediately since each reference arrives as one complete block rather than incremental tokens. Fixes #64658

… is hidden Every moa.reference gateway event stores its labelled reference-model output in a Msg's generic `thinking` field (turnController's recordMoaReference), which messageLine.tsx and the ToolTrail component gate on `display.sections.thinking`'s resolved mode. When that mode resolves to `hidden`, MoA reference blocks were suppressed along with ordinary model reasoning — even though (per #53855) references are the mixture-of-agents process the user explicitly opted into, not private reasoning, and should stay visible regardless of the thinking-section setting. Adds Msg.isMoaReference (set by recordMoaReference), a shouldShowThinkingTrail helper mirroring the existing shouldShowResponseSeparator pattern, and a reasoningAlwaysVisible prop threaded into ToolTrail to bypass the two suppression gates (the trail-wrapper return-null check and the allHidden/panel-push checks) plus the panel's initial open state and the shift-click expand-all gesture, so a MoA reference panel is not just present in the tree but actually visible and openable on first paint. Fixes #64657

…placing Every moa.reference event called appendReasoningDelta(..., replace=true), which wipes ALL existing reasoning-type message parts and seeds exactly one new part. With two or more MoA reference models, each later reference erased the reasoning disclosure built by earlier references, so only the last advisor's output ever stayed visible instead of one labelled block per reference (contradicting the multi-reference visibility behavior from #53855). Only the first reference (index <= 1, or missing) now replaces — preserving the original "clear stale reasoning from before this turn" behavior. Every later reference accumulates via the existing queue-then-flush path instead, applied immediately since each reference arrives as one complete block rather than incremental tokens. Fixes #64658

… is hidden Every moa.reference gateway event stores its labelled reference-model output in a Msg's generic `thinking` field (turnController's recordMoaReference), which messageLine.tsx and the ToolTrail component gate on `display.sections.thinking`'s resolved mode. When that mode resolves to `hidden`, MoA reference blocks were suppressed along with ordinary model reasoning — even though (per #53855) references are the mixture-of-agents process the user explicitly opted into, not private reasoning, and should stay visible regardless of the thinking-section setting. Adds Msg.isMoaReference (set by recordMoaReference), a shouldShowThinkingTrail helper mirroring the existing shouldShowResponseSeparator pattern, and a reasoningAlwaysVisible prop threaded into ToolTrail to bypass the two suppression gates (the trail-wrapper return-null check and the allHidden/panel-push checks) plus the panel's initial open state and the shift-click expand-all gesture, so a MoA reference panel is not just present in the tree but actually visible and openable on first paint. Fixes #64657

…placing Every moa.reference event called appendReasoningDelta(..., replace=true), which wipes ALL existing reasoning-type message parts and seeds exactly one new part. With two or more MoA reference models, each later reference erased the reasoning disclosure built by earlier references, so only the last advisor's output ever stayed visible instead of one labelled block per reference (contradicting the multi-reference visibility behavior from #53855). Only the first reference (index <= 1, or missing) now replaces — preserving the original "clear stale reasoning from before this turn" behavior. Every later reference accumulates via the existing queue-then-flush path instead, applied immediately since each reference arrives as one complete block rather than incremental tokens. Fixes #64658

… is hidden Every moa.reference gateway event stores its labelled reference-model output in a Msg's generic `thinking` field (turnController's recordMoaReference), which messageLine.tsx and the ToolTrail component gate on `display.sections.thinking`'s resolved mode. When that mode resolves to `hidden`, MoA reference blocks were suppressed along with ordinary model reasoning — even though (per #53855) references are the mixture-of-agents process the user explicitly opted into, not private reasoning, and should stay visible regardless of the thinking-section setting. Adds Msg.isMoaReference (set by recordMoaReference), a shouldShowThinkingTrail helper mirroring the existing shouldShowResponseSeparator pattern, and a reasoningAlwaysVisible prop threaded into ToolTrail to bypass the two suppression gates (the trail-wrapper return-null check and the allHidden/panel-push checks) plus the panel's initial open state and the shift-click expand-all gesture, so a MoA reference panel is not just present in the tree but actually visible and openable on first paint. Fixes #64657

… CLI (NousResearch#53855) The MoA reference-block display (each reference model's output shown as a labelled thinking block before the aggregator responds) previously existed only in the classic CLI. The facade already emits moa.reference / moa.aggregating through tool_progress_callback; this wires the TUI and desktop consumers. - tui_gateway/server.py: _on_tool_progress relays moa.reference (label / text / index / count) and moa.aggregating to the Ink/desktop client as their own events. - ui-tui: gatewayTypes adds the two event shapes; createGatewayEventHandler routes them; turnController.recordMoaReference pushes a committed thinking-style segment tagged with the source model. Shown regardless of showReasoning — references ARE the mixture-of-agents process the user opted into, not ordinary reasoning. moa.aggregating is a status-only transition (no transcript entry). - apps/desktop: use-message-stream appends each reference as a labelled reasoning chunk via the existing reasoning disclosure; GatewayEventPayload gains label/index/aggregator. Tests: tui_gateway emit (3), Ink handler render + showReasoning-independence + aggregating-no-segment (3). TUI typecheck/lint clean; desktop typecheck/lint clean.

…placing Every moa.reference event called appendReasoningDelta(..., replace=true), which wipes ALL existing reasoning-type message parts and seeds exactly one new part. With two or more MoA reference models, each later reference erased the reasoning disclosure built by earlier references, so only the last advisor's output ever stayed visible instead of one labelled block per reference (contradicting the multi-reference visibility behavior from NousResearch#53855). Only the first reference (index <= 1, or missing) now replaces — preserving the original "clear stale reasoning from before this turn" behavior. Every later reference accumulates via the existing queue-then-flush path instead, applied immediately since each reference arrives as one complete block rather than incremental tokens. Fixes NousResearch#64658

… is hidden Every moa.reference gateway event stores its labelled reference-model output in a Msg's generic `thinking` field (turnController's recordMoaReference), which messageLine.tsx and the ToolTrail component gate on `display.sections.thinking`'s resolved mode. When that mode resolves to `hidden`, MoA reference blocks were suppressed along with ordinary model reasoning — even though (per NousResearch#53855) references are the mixture-of-agents process the user explicitly opted into, not private reasoning, and should stay visible regardless of the thinking-section setting. Adds Msg.isMoaReference (set by recordMoaReference), a shouldShowThinkingTrail helper mirroring the existing shouldShowResponseSeparator pattern, and a reasoningAlwaysVisible prop threaded into ToolTrail to bypass the two suppression gates (the trail-wrapper return-null check and the allHidden/panel-push checks) plus the panel's initial open state and the shift-click expand-all gesture, so a MoA reference panel is not just present in the tree but actually visible and openable on first paint. Fixes NousResearch#64657

teknium1 force-pushed the hermes/moa-reference-tui-desktop branch from f4bc023 to 7e23cb6 Compare June 27, 2026 23:06

alt-glitch added type/feature New feature or request comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jun 27, 2026

tonydwb approved these changes Jun 28, 2026

View reviewed changes

teknium1 merged commit 163cb24 into main Jun 28, 2026
35 checks passed

teknium1 deleted the hermes/moa-reference-tui-desktop branch June 28, 2026 01:46

sergioperezcheco mentioned this pull request Jun 28, 2026

v0.17.0 Renderer stuck in fontations+temporal_rs loop — GPU 98% active, 13W sustained power draw #53902

Open

BrewTestBot mentioned this pull request Jul 1, 2026

hermes-agent 2026.7.1 Homebrew/homebrew-core#290881

Merged

1 task

github-actions Bot mentioned this pull request Jul 2, 2026

chore: bump NousResearch/hermes-agent version from v2026.6.19 to v2026.7.1 Docker-Hub-sirmark/docker-hermes-agent#12

Merged

This was referenced Jul 14, 2026

[Bug]: TUI hides MoA reference blocks when the thinking section is hidden #64657

Closed

[Bug]: Desktop MoA reference events replace earlier advisor output instead of accumulating #64658

Closed

This was referenced Jul 15, 2026

fix(desktop): accumulate MoA reference reasoning blocks instead of replacing #64689

Closed

fix(tui): keep MoA reference blocks visible when the thinking section is hidden #64701

Closed

Navigation Menu

Uh oh!

feat(moa): render reference-model blocks in TUI and desktop, not just CLI - #53855

feat(moa): render reference-model blocks in TUI and desktop, not just CLI#53855
teknium1 merged 1 commit into
mainfrom
hermes/moa-reference-tui-desktop

teknium1 commented Jun 27, 2026

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

tonydwb left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

teknium1 commented Jun 27, 2026

Summary

Changes

Validation

Infographic

Uh oh!

github-actions Bot commented Jun 27, 2026

🔎 Lint report: hermes/moa-reference-tui-desktop vs origin/main

ruff

ty (type checker)

Uh oh!

tonydwb left a comment

Choose a reason for hiding this comment

Code Review Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

🔎 Lint report: `hermes/moa-reference-tui-desktop` vs `origin/main`