fix: rotate OpenCode pool on monthly usage limit - #53843
Closed
TurgutKural wants to merge 2 commits into
Closed
Conversation
alt-glitch
added
type/bug
Collaborator
Same billing/usage-limit credential-pool-rotation family as merged #32089 and open #36280 / #40073 (issue #36276), but this targets OpenCode's |
tonydwb
approved these changes
Jun 28, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
OpenCode pool rotation on monthly usage limit (5 files). Clean quota recovery fix:
- Extends the existing pool rotation mechanism to handle monthly usage limits
- Adds
days_remainingandreset_datetracking for monthly quotas - Properly rotates to next pool entry when monthly limit is hit
- Includes test coverage for the new rotation logic
Good extension of existing pool rotation infrastructure.
Contributor
Author
|
upstream has broader related usage-limit pool rotation fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoUsageLimitErrormonthly quota responses as billing/usage-limit failures so credential pools rotate immediatelyResets in N dayscooldown messages in API error contextTests
uv run pytest tests/hermes_cli/test_runtime_provider_resolution.py::test_resolve_runtime_provider_api_key_explicit_base_url_keeps_matching_pool tests/run_agent/test_run_agent.py::TestCredentialPoolRecovery::test_recover_with_pool_rotates_first_429_on_usage_limit tests/run_agent/test_run_agent.py::TestCredentialPoolRecovery::test_extract_api_error_context_parses_resets_in_days -q