fix(desktop): respect IME enter in edit composer - #53753
Conversation
8f483d0 to
1f24a1e
Compare
|
Thanks for the focused IME regression fix. The reported behavior still exists on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
1f24a1e to
3374c09
Compare
Follow-up update (author)Rebased onto current What changed
Verification
New head: |
|
This fix landed on main via #86760, which consolidated the duplicate PRs for this bug (earliest submission by @satotakumi in #37487; all contributors credited in that PR's body). Closing as the fix is now merged. Thanks for catching it! |
What does this PR do?
Fixes the desktop app's inline user-message edit composer so Enter during IME composition confirms the candidate text instead of submitting the edited message.
The main message composer already tracks
compositionstart/compositionendand ignores keydown while composing. This applies the same behavior to the current edit composer path (user-edit-composer.tsx), then flushes the finalized composition on composition end.Guards:
nativeEvent.isComposingkeyCode === 229(legacy IME enter on some platforms)Test plan
New head:
3374c099e0dab370f10ce9c421337343bfae1af1