fix(desktop): steer from live composer text - #53660
Closed
supplefrog wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an intermittent Hermes Desktop composer bug where
Ctrl+Enter/Cmd+Entercan miss freshly typed steer text. The shortcut branch now mirrors the existing plain-Enter race fix: it reads the livecontentEditableDOM synchronously before deciding whether steering is possible, then syncsdraftRef/composer state before callingsteerDraft().Related Issue
Fixes #53659
Type of Change
Changes Made
apps/desktop/src/app/chat/composer/index.tsxCtrl/Cmd+Entersteer branch readcomposerPlainText(editorRef.current)instead of relying on render-derivedcanSteer.steerDraft()validate steerability fromdraftRef.currentso the freshly synced text is honored in the same keydown event.apps/desktop/src/app/chat/composer/enter-submit-dom-race.test.tsxCtrl+Entereven before composer state has synced.How to Test
Ctrl+Enter/Cmd+Enter.Local verification:
npm --prefix apps/desktop run typecheck— passednpm --prefix apps/desktop run test:ui -- src/app/chat/composer/enter-submit-dom-race.test.tsx src/app/chat/composer/composer-text-guard.test.tsx— 2 files, 8 tests passednpm --prefix apps/desktop run build— passedgit diff --check— passedChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
No screenshot; this is a keyboard timing fix. The regression is covered by the added jsdom DOM-keydown test.