Skip to content

fix(config): default cli_refresh_interval to 0 to prevent terminal auto-scroll fighting (#53636) #53655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tranquil-Flow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(config): default cli_refresh_interval to 0 to prevent terminal auto-scroll fighting (#53636) #53655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions hermes_cli/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,13 +1895,10 @@ def _ensure_hermes_home_managed(home: Path):
# spinner), or ascii. Live-swappable via `/indicator <style>`.
"tui_status_indicator": "kaomoji",
# Seconds between prompt_toolkit redraws in the classic CLI when idle.
# Default 1.0 keeps the wall-clock status-bar read-outs (idle-since-
# last-turn) ticking and keeps the bottom chrome alive during idle —
# without it prompt_toolkit stops repainting the status bar after a
# turn and it can go stale/disappear (#45592).
# Set 0 to disable the background refresh if it fights terminal
# auto-scroll in non-fullscreen mode on some emulators (#48309).
"cli_refresh_interval": 1.0,
# Default 0 disables background redraws so non-fullscreen terminal
# auto-scroll remains usable (#48309, #53636). Set a positive interval
# (for example 1.0) to keep idle status-bar clocks ticking (#45592).
"cli_refresh_interval": 0.0,
"user_message_preview": { # CLI: how many submitted user-message lines to echo back in scrollback
"first_lines": 2,
"last_lines": 2,
Expand Down
9 changes: 3 additions & 6 deletions tests/hermes_cli/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,12 +1320,9 @@ def test_migrate_to_v15_adds_interim_assistant_message_gate(self, tmp_path):
class TestCliRefreshIntervalConfig:
"""Test the CLI refresh_interval config default (#45592 / #48309)."""

def test_default_config_enables_cli_refresh_interval(self):
"""cli_refresh_interval defaults to 1.0 so the idle status-bar
clock keeps ticking and the bottom chrome stays alive during
idle (#45592). Users on emulators where the periodic redraw
fights auto-scroll can set it to 0 (#48309)."""
assert DEFAULT_CONFIG["display"]["cli_refresh_interval"] == 1.0
def test_default_config_disables_cli_refresh_interval(self):
"""Background redraws default off so they cannot fight scrollback."""
assert DEFAULT_CONFIG["display"]["cli_refresh_interval"] == 0


class TestDiscordChannelPromptsConfig:
Expand Down
Loading