fix(moa): tolerate non-list reference_models in hand-edited MoA preset config - #53556
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
✅ Fixed issues (2):
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:3002: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
Unchanged: 6031 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
13 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A hand-edited non-list
reference_modelsin a MoA preset (e.g.reference_models: 2, or a single slot mapping written without the list wrapper) no longer crashes every MoA operation._normalize_presetruns on every model-selection and MoA turn viaresolve_moa_preset, so the unguarded iteration made the crash unrecoverable until the config was manually fixed.Salvage of #53467 by @briandevans, cherry-picked onto current
main.Changes
hermes_cli/moa_config.py: in_normalize_preset, coerce a non-listreference_modelsbefore iterating — a bare dict is wrapped into a one-element list, anything else falls through to[]so the existing "no refs → defaults" path applies. No behavior change for the normal list case. This completes the same "tolerate hand-edited values" class as the priorf0678b031scalar-field guards;aggregatorwas already safe via_clean_slot's dict check.tests/hermes_cli/test_moa_config.py: regression coverage for a scalar value (degrades to defaults) and a bare-dict value (rescued into a list).Validation
scripts/run_tests.sh tests/hermes_cli/test_moa_config.py→ 15/15 passed.Infographic