Skip to content

fix(skills): resolve symlinks before relative_to in skill install #53541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexFucuson9 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(skills): resolve symlinks before relative_to in skill install #53541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/skills_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3450,7 +3450,7 @@ def install_from_quarantine(
trust_level=bundle.trust_level,
scan_verdict=scan_result.verdict,
skill_hash=content_hash(install_dir),
install_path=str(install_dir.relative_to(SKILLS_DIR)),
install_path=str(install_dir.resolve().relative_to(SKILLS_DIR.resolve())),

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses lock recording, but current main also computes an unresolved relative path in the successful CLI display at hermes_cli/skills_hub.py:731. Please fix that sibling site and cover both paths with one symlink-root regression.

files=list(bundle.files.keys()),
metadata=bundle.metadata,
)
Expand Down