fix(kimi): add kimi-k2.7-code to kimi-coding-cn and moonshot model lists - #53532
Open
wwwqqqzzz wants to merge 1 commit into
Open
fix(kimi): add kimi-k2.7-code to kimi-coding-cn and moonshot model lists#53532wwwqqqzzz wants to merge 1 commit into
wwwqqqzzz wants to merge 1 commit into
Conversation
The kimi-k2.7-code model was listed in kimi-coding provider model list but missing from kimi-coding-cn and moonshot provider lists in hermes_cli/models.py, and from both kimi-coding and kimi-coding-cn lists in hermes_cli/setup.py. Add it as the first entry in all four lists, matching the existing kimi-k2.7-code entry in the kimi-coding list. Closes NousResearch#53520
alt-glitch
added
type/feature
tonydwb
approved these changes
Jun 27, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Adds kimi-k2.7-code to the kimi-coding-cn and moonshot model lists, and to the kimi-coding and kimi-coding-cn provider pool setup.
Looks Good
- Model added to both curated lists and pool setup consistently
- Correct placement at the top of each list (newest model first)
- Minimal 4-line change across 2 files
Reviewed by Hermes Agent
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracing the missing curated entries.
Problems
hermes_cli/setup.py:102-103is an unreferenced_DEFAULT_PROVIDER_MODELSduplicate. The active Kimi wizard imports the canonical catalog fromhermes_cli.modelsathermes_cli/model_setup_flows.py:1902and selects its endpoint-specific list at line 1936, so those two setup edits have no current runtime effect.- The active flow intentionally distinguishes
sk-kimi-*Coding Plan keys from legacy Moonshot keys athermes_cli/model_setup_flows.py:1923-1936. Please verify K2.7 Code is available on the legacy and China endpoints before expanding both corresponding lists.
Suggested changes
- Drop the unused
setup.pyedits and add a focused test for the confirmed endpoint-specific catalog behavior.
Automated hermes-sweeper review.
| "zai": ["glm-5.2", "glm-5.1", "glm-5", "glm-4.7", "glm-4.5", "glm-4.5-flash"], | ||
| "kimi-coding": ["kimi-k2.6", "kimi-k2.5", "kimi-k2-thinking", "kimi-k2-turbo-preview"], | ||
| "kimi-coding-cn": ["kimi-k2.6", "kimi-k2.5", "kimi-k2-thinking", "kimi-k2-turbo-preview"], | ||
| "kimi-coding": ["kimi-k2.7-code", "kimi-k2.6", "kimi-k2.5", "kimi-k2-thinking", "kimi-k2-turbo-preview"], |
Contributor
There was a problem hiding this comment.
_DEFAULT_PROVIDER_MODELS is currently unreferenced outside this definition; the live Kimi setup flow imports hermes_cli.models._PROVIDER_MODELS instead. Please remove this duplicate-catalog change rather than maintaining a dead second list.
teknium1
added
sweeper:risk-compatibility
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
kimi-k2.7-codemodel was listed in thekimi-codingprovider model list but missing from:kimi-coding-cninhermes_cli/models.pymoonshotinhermes_cli/models.pykimi-codingandkimi-coding-cninhermes_cli/setup.pyChanges
hermes_cli/models.py: Added"kimi-k2.7-code"as first entry inkimi-coding-cnandmoonshotprovider model listshermes_cli/setup.py: Added"kimi-k2.7-code"as first entry inkimi-codingandkimi-coding-cnprovider model listsRelated
Closes #53520