fix(gateway): show MoA presets in model picker - #53526
Closed
dodo-reach wants to merge 1 commit into
Closed
Conversation
dodo-reach
force-pushed
the
pr/gateway-moa-picker-presets
branch
from
June 27, 2026 09:19
45b44a1 to
28eaf02
Compare
tonydwb
approved these changes
Jun 27, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Shows MoA presets as a virtual provider in the gateway model picker, making them tappable like normal providers.
Looks Good
_prepend_moa_picker_providercorrectly builds a virtual provider row with preset names as modelsinclude_moaflag is opt-in (defaults to False) — backward compatible- Deduplication: existing
moaentries are filtered out before prepending - Good test coverage: tests for the virtual provider row structure, current-provider detection, and the gateway picker path
- Complements PR #53548 (which makes /moa one-shot only and routes preset switching through this picker)
Reviewed by Hermes Agent
Contributor
|
Merged via #53561 — your commits were cherry-picked onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the gateway
/modelpicker so MoA presets appear as selectable models under the virtualmoaprovider.MoA presets are already exposed in the CLI inventory, and the docs say presets are selectable across Hermes surfaces. However, the gateway picker path calls
list_picker_providers()directly, bypassing the CLI inventory code that injects the virtual MoA provider row. As a result, Telegram/Discord-style model pickers showed only real providers/models, not MoA presets.This adds an explicit
include_moaopt-in tolist_picker_providers()and enables it from the gateway/modelpicker path. Existing callers keep the old behavior unless they opt in.Related Issue
Related to #46081 and #53211, which made/documented MoA presets as selectable virtual models. This PR fixes the gateway picker path that still missed that virtual provider.
Type of Change
Changes Made
hermes_cli/model_switch.pylist_picker_providers()behavior unchanged unlessinclude_moa=True.gateway/slash_commands.pyinclude_moa=Truefor the gateway/modelpicker path.tests/hermes_cli/test_list_picker_providers.pytests/gateway/test_model_command_async_offload.pyHow to Test
config.yaml./model.Mixture of Agentsappears as a provider and its preset names are selectable.Automated tests run locally:
Result:
Manual verification:
/modelshowed regular providers only./modelshows the MoA virtual provider and presets (default,battle,smart) as selectable options.Checklist
Code
fix(scope):,feat(scope):, etc.)scripts/run_tests.shand all tests passDocumentation & Housekeeping
docs/, docstrings) — N/A; existing docs already describe MoA preset selection across surfacescli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AScreenshots / Logs