Skip to content

feat: Add Persian (fa) localization - #53396

Closed
m4tinbeigi-official wants to merge 1 commit into
NousResearch:mainfrom
m4tinbeigi-official:feature/persian-translation
Closed

feat: Add Persian (fa) localization#53396
m4tinbeigi-official wants to merge 1 commit into
NousResearch:mainfrom
m4tinbeigi-official:feature/persian-translation

Conversation

@m4tinbeigi-official

Copy link
Copy Markdown

Adds full Persian (Farsi) language support for Hermes CLI and gateway messages.

@m4tinbeigi-official
m4tinbeigi-official requested a review from a team June 27, 2026 03:52
@alt-glitch alt-glitch added invalid This doesn't seem right P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels Jun 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

This PR is a whole-fork push (5,655 files, ~2M deletions) titled as a Persian localization. The actual localization is the clean 4-file PR #53398 — please use that one. Marking this as invalid + duplicate of #53398.

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment (high surface area / destructive)

This PR has 382 additions and 2,063,635 deletions across 300+ files. The diff exceeds GitHub's 300-file limit (HTTP 406). The metadata shows every file in the repository has 0 additions and massive deletions (e.g., AGENTS.md: -1370, cli.py: -1274, gateway/run.py: -9657).

This appears to be a fork-specific or destructive PR that would delete the entire codebase. The PR title says "Persian localization" but the changes do not match that description.

Recommendation: This PR should be closed. It does not appear to be a legitimate contribution.


Reviewed by Hermes Agent

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the Persian localization contribution.

This automated hermes-sweeper review found that this submitted PR does not match its stated scope and cannot be reviewed as a localization change:

  • Commit 208f7f1f22e2b1902b13b957dd2c5ebf07a878cf is +382/-2,063,635 across 5,655 files, including removal of core source, tests, and CI workflows.
  • The linked PR feat: Add Persian (fa) localization #53398 is the focused Persian-localization alternative: GitHub reports four changed files and +395/-1.
  • Current main still lacks fa in agent/i18n.py:43-46, so the localization request itself is not being dismissed; this PR's submitted tree is simply not a coherent vehicle for it.

Closing this PR as incoherent; the focused implementation can be evaluated separately.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:incoherent Sweeper: insufficient/incoherent to action label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists invalid This doesn't seem right P3 Low — cosmetic, nice to have sweeper:incoherent Sweeper: insufficient/incoherent to action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants