[DRAFT] fix(agent): route copilot-acp through non-streaming request flow - #5336
Closed
MestreY0d4-Uninter wants to merge 2 commits into
Closed
[DRAFT] fix(agent): route copilot-acp through non-streaming request flow#5336MestreY0d4-Uninter wants to merge 2 commits into
MestreY0d4-Uninter wants to merge 2 commits into
Conversation
added 2 commits
April 5, 2026 21:15
(cherry picked from commit 6517c52)
(cherry picked from commit 0e7d26a88def809478f4136d4cdfeeebb8d1d76a)
This was referenced Apr 5, 2026
Contributor
Author
|
Stacked follow-up to #4536. Opened as draft to avoid upstream drift while the base ACP tool-call bridge is still pending. Related follow-ups in the same stack:
|
Contributor
Author
|
Closing as stale/superseded by later ACP integration changes. I re-audited this against a clean origin/main worktree: the copilot-acp/run_agent integration area has evolved since this stacked draft was opened, so this PR is no longer the right review unit on top of current main. If there is still a remaining non-streaming gap, I'll re-extract it as a fresh focused PR against current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4536.
Please review/merge this after the ACP tool-call bridge lands, since this follow-up assumes that base behavior.
I’m opening it early to reduce the risk of upstream drift while
#4536is still pending.Summary
This PR fixes the
run_agent.pyintegration path forcopilot-acp.ACP should not go through the generic streaming request flow used by other providers. Doing so can lead to double-send behavior and makes interruption/abort handling less reliable.
What changed
copilot-acpWhy
The ACP client became much stronger after the tool-call bridge, but
run_agent.pystill treated it too much like a generic provider.This PR fixes that integration mismatch.
Validation
Automated
python3 -m py_compile agent/copilot_acp_client.py run_agent.py tests/test_run_agent.pyuv run --extra dev python -m pytest -o addopts='' tests/test_run_agent.py -q -k 'CopilotAcpIntegration or CopilotAcpNotice'5 passed, 226 deselectedManual
Validated end-to-end on the rebased branch with a real
AIAgent(provider='copilot-acp')run:Reply exactly ACP_OKACP_OKNotes
This PR is about correct ACP integration in the main agent loop.
It does not change broader routing policy beyond the ACP-specific request path.