Skip to content

fix(terminal): suppress Windows desktop terminal console flashes - #53358

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/53273-terminal-breakaway
Closed

fix(terminal): suppress Windows desktop terminal console flashes#53358
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/53273-terminal-breakaway

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • opt windows_hide_flags() into CREATE_BREAKAWAY_FROM_JOB for Desktop/Electron terminal launches
  • retry hidden local bash spawns once without breakaway when Windows denies that flag
  • add regression tests for the hide-flag bundle and the LocalEnvironment retry path

Verification

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows labels Jun 27, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Clean fix for Windows desktop terminal console flashes. Adds breakaway_from_job parameter to windows_hide_flags() for callers running under a Desktop/Electron job object where CREATE_NO_WINDOW alone still allows a visible console flash. Well-documented with clear rationale.

Looks Good

  • Correct parameter addition with clear documentation
  • Backward compatible (default breakaway_from_job=False)
  • Good test coverage
  • No security concerns

Reviewed by Hermes Agent

@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by the consolidated Windows console-flash work tracked in #54220.

The relevant pieces from this PR/cluster have now landed through the targeted follow-up PRs #54236, #53892, and #54417, or are recorded in the umbrella tracker for any remaining native-Windows verification. Keeping this separate PR open would duplicate the tracker and the merged follow-up work.

Thanks for digging into this — the reports and PRs in this cluster helped identify the remaining spawn legs.

@teknium1 teknium1 closed this Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants