fix(terminal): suppress Windows desktop terminal console flashes - #53358
fix(terminal): suppress Windows desktop terminal console flashes#53358LeonSGP43 wants to merge 1 commit into
Conversation
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Clean fix for Windows desktop terminal console flashes. Adds breakaway_from_job parameter to windows_hide_flags() for callers running under a Desktop/Electron job object where CREATE_NO_WINDOW alone still allows a visible console flash. Well-documented with clear rationale.
Looks Good
- Correct parameter addition with clear documentation
- Backward compatible (default breakaway_from_job=False)
- Good test coverage
- No security concerns
Reviewed by Hermes Agent
|
Closing as superseded by the consolidated Windows console-flash work tracked in #54220. The relevant pieces from this PR/cluster have now landed through the targeted follow-up PRs #54236, #53892, and #54417, or are recorded in the umbrella tracker for any remaining native-Windows verification. Keeping this separate PR open would duplicate the tracker and the merged follow-up work. Thanks for digging into this — the reports and PRs in this cluster helped identify the remaining spawn legs. |
Summary
windows_hide_flags()intoCREATE_BREAKAWAY_FROM_JOBfor Desktop/Electron terminal launchesVerification
uv run python --versionuv run --with pytest python -m pytest tests/tools/test_windows_native_support.py -k 'SubprocessCompatHelpers or LocalEnvironment'\n-uv run --extra dev python -m ruff check hermes_cli/_subprocess_compat.py tools/environments/local.py tests/tools/test_windows_native_support.py\n-git diff --check\n\nFixes Windows Desktop GUI: CREATE_NO_WINDOW insufficient — cmd windows flash on every terminal() call #53273