fix(feishu): add extra_ua_tags=["channel"] to FeishuWSClient for group @mention delivery - #52908
luxuguang-leo wants to merge 1 commit into
Conversation
…p @mention delivery Without this UA tag the Feishu server does not push group @mention events over the WebSocket transport. The "channel" tag tells the server to use the Channel protocol which enables group-message routing in addition to P2P direct messages. Root cause: FeishuWSClient was created without any UA signaling tag, so the server defaulted to the basic DM-only push mode. Group @mention events were silently dropped before reaching Hermes. Fixes NousResearch#50656 Also adds a regression test verifying the UA tag is present in the FeishuWSClient constructor call.
Fix PR for #50656 (Feishu group @mention messages not delivered over WebSocket). The |
|
I successfully used this method to get the AI to fix the Lark group chat function. Please release it in the latest version as soon as possible. Thank you. |
|
Quick check-in on this one. Same situation as my other PRs — the check suites are stuck at This fixes group @mention delivery over WebSocket on Feishu — |
|
Merged via PR #61770. Your Feishu Channel signaling fix was cherry-picked onto current main, the shipped SDK dependency was upgraded to support the new constructor argument, and real SDK compatibility coverage was added. Your authorship is preserved in git history. Thank you. |
Problem
Group @mention messages are not delivered over WebSocket transport.
The Feishu server silently drops group events because the WebSocket
connection was not tagged as a "channel" connection.
Root Cause
FeishuWSClientwas created without any UA signaling tag. The serverdefaulted to basic DM-only push mode and never sent group @mention events.
Fix
Added
extra_ua_tags=["channel"]to theFeishuWSClientconstructor callin
_connect_websocket(). This tells the Feishu server to use the Channelprotocol, which enables group-message routing in addition to P2P DM.
The native
lark_oapi.channel.FeishuChanneluses the same mechanisminternally (verified against lark_oapi source).
Fixes #50656
Testing
test_connect_websocket_sets_channel_ua_tagReferences