Skip to content

fix(skills): respect local skill dir in skill manager - #5284

Closed
malaiwah wants to merge 1 commit into
NousResearch:mainfrom
malaiwah:codex/skill-manager-find-skill
Closed

fix(skills): respect local skill dir in skill manager#5284
malaiwah wants to merge 1 commit into
NousResearch:mainfrom
malaiwah:codex/skill-manager-find-skill

Conversation

@malaiwah

@malaiwah malaiwah commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore local-first skill lookup in skill_manager_tool
  • keep support for skills.external_dirs
  • add regression coverage for patched SKILLS_DIR and external dir lookup

Related

Testing

  • source /Users/mbelleau/Projects/hermes-agent/venv/bin/activate && python -m pytest tests/tools/test_skill_manager_tool.py -q

@trevorgordon981

Copy link
Copy Markdown
Contributor

Small, targeted fix for #4759. Regression coverage for both patched SKILLS_DIR and external_dirs lookup paths is included. Affects anyone shipping local skills (hi). Proceed.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the fix, @malaiwah! This bug is already resolved on main.

Commit ad4feeaf0 (feat: wire skills.external_dirs into all remaining discovery paths) shipped the same fix — _find_skill() in tools/skill_manager_tool.py now calls get_all_skills_dirs() (line 241) instead of only scanning SKILLS_DIR, which includes external dirs in local-first order.

  • tools/skill_manager_tool.py:241 — current main already uses from agent.skill_utils import get_all_skills_dirs inside _find_skill()
  • agent/skill_utils.py:227-234get_all_skills_dirs() returns [get_skills_dir()] + get_external_skills_dirs(), covering the local-first + external_dirs behavior
  • Commit ad4feeaf0 explicitly lists skill_manager_tool._find_skill(): search all dirs for edit/patch/delete in its message

This is an automated hermes-sweeper review. If you believe the fix on main doesn't fully cover your use case, feel free to reopen with a repro that fails against current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skill_manage patch/edit/delete can't find skills from external_dirs

4 participants