fix(desktop): show remote backend updates without counts - #52828
Merged
OutThisLife merged 1 commit intoJun 26, 2026
Conversation
helix4u
marked this pull request as ready for review
June 26, 2026 03:42
tonydwb
approved these changes
Jun 26, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Fixes the update indicator not showing when the backend cannot count commits behind (e.g. Nix-managed installs where behind is -1 but update_available is true).
Looks Good
- Adds
updateAvailablefield toDesktopUpdateStatusinterface, propagated fromupdate_availablein the backend check response - All UI consumers (status bar, updates overlay, idle view) updated to use the new field instead of
behind > 0 banner.pyfix correctly mapsUPDATE_AVAILABLE_NO_COUNTto1for the CLI banner- Test coverage: new test for
behind: -1, update_available: truecase, existing test updated - Clean, focused, backward-compatible
Reviewed by Hermes Agent
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…d-update-indicator fix(desktop): show remote backend updates without counts
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…d-update-indicator fix(desktop): show remote backend updates without counts
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…d-update-indicator fix(desktop): show remote backend updates without counts
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…d-update-indicator fix(desktop): show remote backend updates without counts
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…d-update-indicator fix(desktop): show remote backend updates without counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the remote Desktop backend update indicator when the connected backend reports that an update is available but cannot provide an exact commit count.
The backend update API already distinguishes
update_availablefrombehind; for presence-only update checks it can returnbehind: -1withupdate_available: true. Desktop was collapsing that intobehind: 0, which made the remote backend statusbar/overlay look up to date even when the backend reported an available update.This also aligns official-SSH git backend update checks with the Desktop client checker by returning
1when the backend HEAD differs from upstream, without runninggit fetchor hitting SSH auth.Related Issue
Discord support thread:
1519895846533988454(No remote gateway updates count)Type of Change
Changes Made
update_availablein Desktop update state instead of deriving availability only from a positivebehindcount.1for official-SSH git backend checkouts when HEAD differs from upstream, matching the Desktop client update count behavior while still avoiding SSH fetch/auth prompts.How to Test
scripts/run_tests.sh -j 4 tests/hermes_cli/test_update_check.py tests/hermes_cli/test_dashboard_admin_endpoints.py::TestUpdateCheckEndpointvenv/bin/python -m pytest tests/hermes_cli/test_dashboard_admin_endpoints.py::TestUpdateCheckEndpoint -qnpm exec vitest run src/store/updates.test.ts -- --environment jsdom --maxWorkers 4fromapps/desktop/npm --prefix apps/desktop run typecheckChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
Targeted checks passed:
scripts/run_tests.sh -j 4 tests/hermes_cli/test_update_check.py tests/hermes_cli/test_dashboard_admin_endpoints.py::TestUpdateCheckEndpoint→15 passedvenv/bin/python -m pytest tests/hermes_cli/test_dashboard_admin_endpoints.py::TestUpdateCheckEndpoint -q→7 passednpm exec vitest run src/store/updates.test.ts -- --environment jsdom --maxWorkers 4→22 passednpm --prefix apps/desktop run typecheck→ passed