fix: add Discord threaded free-response channels - #52802
Open
itsflownium wants to merge 1 commit into
Open
Conversation
tonydwb
approved these changes
Jun 26, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Looks Good
- Clean extraction of
_discord_channel_id_set()as a reusable static method - New
_discord_free_response_thread_channels()follows the same pattern - Proper config + env var fallback chain
- Well-documented with clear docstrings
- Feature is additive — no breaking changes to existing behavior
Reviewed by Hermes Agent
Contributor
|
Thanks for targeting a real Discord routing gap: current main still makes Problems
Suggested changes
Automated hermes-sweeper review. |
itsflownium
force-pushed
the
fix/discord-free-response-threads-52766
branch
from
July 15, 2026 07:32
bfd19c8 to
8360cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Add discord.free_response_thread_channels / DISCORD_FREE_RESPONSE_THREAD_CHANNELS for mention-free Discord channels that still use automatic threading.\n- Keep existing free_response_channels behavior inline by skipping thread creation only for the original list.\n- Apply the new setting to the early human-mention gate, while retaining mention filtering in all other channels.\n- Add Discord adapter regression tests and document the setting.\n\nValidation\n- 80 focused Discord tests\n- Ruff on the changed adapter and tests\n\nFixes #52766