fix(slack): render markdown tables as Block Kit tables - #52746
Closed
changhow wants to merge 1 commit into
Closed
Conversation
changhow
force-pushed
the
feat/slack-native-table-blocks
branch
from
June 26, 2026 00:09
3bcbe25 to
c713c4e
Compare
Contributor
|
Superseded by #56102 (#56102), a broader opt-in Slack Block Kit renderer that includes native table blocks (per-column alignment, inline-formatted cells, monospace fallback over Slack's limits) and closes #18918. This was one of several independent fixes for the same area — thanks for contributing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tableblockssectionblocks and keep existing text/mrkdwn fallback behaviorFixes #18918.
Note: there are older open PRs around this issue, but the active Slack implementation on
mainnow lives underplugins/platforms/slack/adapter.py; this PR targets that current plugin path.Behavior / safeguards
raw_textcells after stripping Markdown delimiters that Slack table cells do not parsechat.updatewhen the edited text no longer contains a tableTests
python3 -m ruff check plugins/platforms/slack/adapter.py tests/gateway/test_slack.pygit show --check --pretty=format: HEAD -- plugins/platforms/slack/adapter.py tests/gateway/test_slack.py website/docs/user-guide/messaging/slack.mdpython3 -m py_compile plugins/platforms/slack/adapter.py tests/gateway/test_slack.pypython3 -m pytest tests/gateway/test_slack.py tests/gateway/test_send_multiple_images.py::TestSlackMultiImage -q -o 'addopts='— 218 passed, 38 pre-existing async mock warningsSecurity / review