Skip to content

feat(delegate): support per-task model and reasoning_effort in delegate_task - #52693

Closed
neaucode-bot wants to merge 1 commit into
NousResearch:mainfrom
neaucode-bot:neaucode/delegate-per-task-model-effort
Closed

feat(delegate): support per-task model and reasoning_effort in delegate_task#52693
neaucode-bot wants to merge 1 commit into
NousResearch:mainfrom
neaucode-bot:neaucode/delegate-per-task-model-effort

Conversation

@neaucode-bot

Copy link
Copy Markdown

delegate_task now accepts top-level and per-task model and reasoning_effort. Per-task values resolve in order: per-task -> delegation.reasoning_effort config -> parent inheritance. _dispatch_delegate_task forwards both so they reach _build_child_agent, and DELEGATE_TASK_SCHEMA exposes the new fields on both the top-level and per-task shapes.

Covers schema, dispatch, and child-build paths with tests.

Made with Cursor

…te_task

delegate_task now accepts top-level and per-task `model` and `reasoning_effort`.
Per-task values resolve in order: per-task -> delegation.reasoning_effort config
-> parent inheritance. _dispatch_delegate_task forwards both so they reach
_build_child_agent, and DELEGATE_TASK_SCHEMA exposes the new fields on both the
top-level and per-task shapes. Covers schema, dispatch, and child-build paths
with tests.

Co-authored-by: neaucode <3423750+neaucode@users.noreply.github.com>
@alt-glitch alt-glitch added type/feature New feature or request tool/delegate Subagent delegation comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jun 25, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #50465 — both add per-task model and reasoning_effort to delegate_task (same run_agent.py dispatch + tools/delegate_tool.py schema paths). #50465 is the earlier, more comprehensive open PR (also adds per-task credential resolution for batch fan-out); this is the narrower subset in the same saturated per-call-model-override cluster. Marking duplicate so reviewers consolidate on the superset PR.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused implementation and tests.

This automated hermes-sweeper review is closing this under the standing delegation-model-routing policy: delegate_task does not support model-facing per-call or per-task model/provider/reasoning routing. The supported control is the profile-level delegation.provider, delegation.model, and delegation.reasoning_effort configuration.

  • Current main states this contract directly in tools/delegate_tool.py:3296.
  • The configuration path is documented in website/docs/user-guide/configuration.md:1936-1944.
  • This is the same feature cluster as feat(delegation): support per-call child model overrides #50465, where a maintainer explicitly rejected the approach (We do not want this, July 5, 2026).

If a different delegation behavior is needed, please re-scope it around the existing delegation.* configuration mechanism rather than adding per-call routing fields to the tool schema.


Closed as not-planned per standing maintainer policy (delegation-model-routing). This is a design-direction decision, not a code-quality judgment — see the Contribution Rubric in AGENTS.md for what the project is looking for. If you believe this policy was misapplied to your change, comment here and a maintainer will take a look.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:not-planned Sweeper: closed per standing maintainer policy (design direction) sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/delegate Subagent delegation type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants