Skip to content

fix(skills): align inspect with runtime skill commands - #52545

Open
batufirat-hub wants to merge 1 commit into
NousResearch:mainfrom
batufirat-hub:fix/skills-inspect-runtime-skill
Open

batufirat-hub wants to merge 1 commit into
NousResearch:mainfrom
batufirat-hub:fix/skills-inspect-runtime-skill

Conversation

@batufirat-hub

Copy link
Copy Markdown

Summary

  • Prefer installed runtime slash-command skills for bare hermes skills inspect <name> lookups.
  • Keep explicit hub identifiers (owner/repo/...) on the hub preview path.
  • Surface disabled local skills instead of silently falling back to hub preview.
  • Warn before hub fallback when runtime skill lookup fails.
  • Add filesystem-backed regression coverage for runtime parity, disabled skills, duplicate names, case variants, parent-dir false matches, and lookup-error fallback.

Test Plan

  • python3 -m py_compile hermes_cli/skills_hub.py tests/hermes_cli/test_skills_hub.py
  • uv run --with pytest --with pytest-xdist --with pyyaml python -m pytest tests/hermes_cli/test_skills_hub.py -q -o 'addopts=' — 36 passed
  • hermes --profile coding skills inspect review — installed local skill, enabled
  • hermes --profile coding skills inspect skills-sh/mattpocock/skills/review — explicit hub preview still works
  • Runtime /review command-map smoke — registered, resolves, invocation builds

Prefer installed runtime skill commands for bare skills inspect names so the CLI preview matches slash-command resolution while explicit hub identifiers still preview hub skills.\n\nAlso surface disabled local skills instead of silently falling back to hub preview, warn on runtime lookup errors, and add filesystem-backed regression coverage.
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard tool/skills Skills system (list, view, manage) P3 Low — cosmetic, nice to have labels Jun 25, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused runtime-parity fix. Current main still sends bare skills inspect identifiers through hub-only resolution (hermes_cli/skills_hub.py:795-800), while slash commands enumerate installed and external skills with normalized command keys and recorded skill_md_path values (agent/skill_commands.py:320-382). The PR addresses that live mismatch while retaining the existing slash-containing identifier path for hub previews.

Automated hermes-sweeper review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants