Skip to content

fix(slack): check Block Kit blocks for @mentions, not just flat text #52404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
Closed

fix(slack): check Block Kit blocks for @mentions, not just flat text #52404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions plugins/platforms/slack/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2578,10 +2578,15 @@ async def _handle_slack_message(self, event: dict) -> None:
# 3. The message is in a thread where the bot was previously @mentioned, OR
# 4. There's an existing session for this thread (survives restarts)
bot_uid = self._team_bot_user_ids.get(team_id, self._bot_user_id)
routing_text = original_text or ""
# Check both flat text and blocks text for mentions — Block Kit
# messages may have the @mention only in blocks, not in the flat
# text field (#52387).
blocks = event.get("blocks")
blocks_text = _extract_text_from_slack_blocks(blocks) if blocks else ""
mention_text = (original_text or "") + ("\n" + blocks_text if blocks_text else "")

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_extract_text_from_slack_blocks() includes nested rich_text_quote content, so this makes a quoted/forwarded <@bot> satisfy routing. Current main deliberately rejects that case in tests/gateway/test_slack.py:1687-1721; use a detector that collects only non-quoted user elements instead.

is_mentioned = bool(
(bot_uid and f"<@{bot_uid}>" in routing_text)
or self._slack_message_matches_mention_patterns(routing_text)
(bot_uid and f"<@{bot_uid}>" in mention_text)
or self._slack_message_matches_mention_patterns(mention_text)
)
event_thread_ts = event.get("thread_ts")
is_thread_reply = bool(event_thread_ts and event_thread_ts != ts)
Expand Down