fix: remove useless f-string prefix from 197 static strings (batch 10 - final) - #52291
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
… - final)
Removes the last remaining useless f-string prefixes from the
codebase. All strings with no {expressions} have been cleaned up
across 10 batches.
Fixes 197 occurrences in 32 files (batch 10 - final cleanup):
- agent/ (5 files): chat_completion_helpers, tool_dispatch_helpers, secret_scope
- hermes_cli/ (10 files): gateway, kanban_db, service_manager, model_switch, doctor, etc.
- tools/ (8 files): skills_sync, approval, mcp_tool, process_registry, etc.
- plugins/ (3 files): video_gen/fal, memory/honcho, google_chat
- cron/ (1 file): jobs
- scripts/ (1 file): release
- optional-skills/ (4 files): various
Total across all 10 batches: ~1,200 fixes in ~70 files.
alt-glitch
added
type/refactor
tonydwb
approved these changes
Jun 25, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Final batch of f-string prefix removal (batch 10 - final). Pure mechanical cleanup removing useless f prefix from static strings across 32 files. No logic changes. Well-documented with total count across all 10 batches (~1,200 fixes in ~70 files).
Changes:
- 32 files: 197 additions/deletions — pure
fprefix removal from static strings
LGTM.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final batch of useless f-string prefix removal. Removes
fprefix from all remaining strings that contain no{expressions}.Files changed (197 fixes in 32 files)
agent/hermes_cli/tools/plugins/cron/scripts/optional-skills/Follow-up to batches 1-9 (#52254, #52258, #52262, #52268, #52269, #52274, #52278, #52280, #52281).
Total across all 10 batches: ~1,200 fixes in ~70 files.