feat(agent): record coding verification evidence - #52285
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
✅ Fixed issues (1):
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
Unchanged: 5940 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
Record foreground verification commands in a bounded, profile-scoped ledger and mark evidence stale when code edits change the workspace.
Exercise command classification, session scoping, stale edits, bounded retention, and natural expiry for recorded verification evidence.
OutThisLife
force-pushed
the
bb/verify-ledger
branch
from
June 25, 2026 03:35
7390aff to
f0beb6f
Compare
This was referenced Jun 25, 2026
tonydwb
approved these changes
Jun 25, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Well-structured verification evidence ledger. The module is intentionally passive — recording evidence without making guarantees. Good design with bounded storage, scoped evidence (full vs targeted), and natural expiration. Comprehensive test coverage.
Changes:
agent/verification_evidence.py: New 547-line module with SQLite-backed evidence ledgertests/agent/test_verification_evidence.py: 313 lines of teststools/file_tools.py: 44 additions for file mutation trackingtools/terminal_tool.py: 29 additions for terminal result recording
LGTM.
Reviewed by Hermes Agent
1 task
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
feat(agent): record coding verification evidence
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
feat(agent): record coding verification evidence
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
feat(agent): record coding verification evidence
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
feat(agent): record coding verification evidence
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
feat(agent): record coding verification evidence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent.coding_contextfullvstargeted, pass vs fail)session_idwhile preserving rawtask_idfor sandbox/file resolutionwrite_file/patchedits, using the edited file's project root when availablepnpm test,bash scripts/run_tests.sh,uv run pytest) while avoiding echoed command text false positivesNotes
This is intentionally passive: it records evidence, not guarantees. A targeted test stays targeted, lint/typecheck/build are classified separately, and no stop-loop or desktop UI policy is added in this PR.
Test plan
scripts/run_tests.sh tests/agent/test_verification_evidence.py tests/agent/test_coding_context.py -- -q