fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang - #52187
Merged
Merged
Conversation
…ss TTS hang Three voice-mode papercuts in the desktop app: 1. Ctrl+B did nothing. The docs + `voice.record_key` advertise Ctrl+B to talk, but the desktop never bound it (only ⌘B = sidebar existed). Add a rebindable `composer.voice` action that toggles the voice conversation, defaulting to ⌃B on macOS (distinct from ⌘B; off-macOS `ctrl` folds to the sidebar chord, so it ships unbound there to avoid stealing it). The global keybind reaches the composer through a new focus-bus event. 2. The Voice settings page rendered every provider's options at once (~30 fields). Filter to the *selected* TTS/STT provider's sub-fields; STT provider fields hide when STT is off. Picking "edge" now shows just the Edge voice, making it obvious voice chat also needs STT enabled. 3. Voice mode could hang "speaking" forever. Free Edge TTS sometimes returns audio that never fires `playing`/`ended`/`error`, so the playback promise never settled. Add a stall watchdog (rearmed on each progress tick, so long speech is never cut off) that rejects a stuck stream, letting the loop recover with a clear error.
alt-glitch
added
type/bug
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
fix(desktop): wire Ctrl+B voice, declutter voice settings, stop endless TTS hang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three voice-mode bugs in the desktop app:
1. Ctrl+B never triggered voice
The voice docs and the
voice.record_keysetting (defaultctrl+b) advertise Ctrl+B to talk, but the desktop app never bound it —⌘B/Ctrl+Bonly toggled the sidebar. Added a rebindablecomposer.voicekeybind that toggles the voice conversation:⌃B(literal Control+B), distinct from the⌘Bsidebar toggle — matches the docs exactly.ctrlfolds into themodaccelerator, which is the long-standing sidebar chord, so it ships unbound there (assignable in the shortcuts panel) rather than hijacking the sidebar.The global keybind reaches the composer (which owns the voice state) via a new
requestVoiceToggle()focus-bus event. Starting with STT unconfigured surfaces the existing "configure speech-to-text" notice instead of silently no-opping.2. The Voice settings page was a wall of fields
Every TTS/STT provider's options rendered simultaneously (~30 rows), so setting "edge free" was buried in OpenAI/ElevenLabs/xAI/MiniMax/… fields. Now only the selected provider's sub-fields show (
voiceFieldVisible), and STT provider fields hide when STT is disabled — making it clear that voice chat needs both a TTS provider and STT enabled.3. Voice mode hung "speaking" forever
Free Edge TTS occasionally returns audio that never fires
playing/ended/error, soplaySpeechText's playback promise never settled and the conversation stuck inspeaking. Added a stall watchdog — rearmed on everytimeupdate, so legitimately long speech is never cut off — that rejects a stuck stream so the loop recovers with a clear error.Test plan
vitest run apps/desktop/src/app/settings/voice-field-visible.test.ts(new) — provider filter incl. STT-disabled + provider-switch cases.tsc -p apps/desktop --noEmiteslinton changed files (no new issues).