fix(web): use SDK-native keyless support in firecrawl-py 4.30+ - #52122
Closed
waiwaic wants to merge 1 commit into
Closed
fix(web): use SDK-native keyless support in firecrawl-py 4.30+#52122waiwaic wants to merge 1 commit into
waiwaic wants to merge 1 commit into
Conversation
firecrawl-py 4.30+ natively supports keyless construction — the v2 client falls back to the keyless free tier (rate-limited per IP) when no FIRECRAWL_API_KEY is set. Changes: - Bump firecrawl-py from 4.17.0 to 4.30.2 - check_firecrawl_api_key() always returns True (SDK handles keyless) - _get_firecrawl_client() gracefully falls back to v2 keyless client when no credentials exist (v1 still requires API key) - Remove the custom _KeylessFirecrawlClient HTTP client entirely - Update error messages and docstrings to mention keyless flow
alt-glitch
added
type/bug
Collaborator
Related: #49912 (the issue this implements) and competing PR #50659. Both target Firecrawl keyless mode but via different mechanisms — #50659 adds a custom |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl-py 4.30+ natively supports keyless construction — firecrawl.Firecrawl v2 client falls back to the keyless free tier (rate-limited per IP) when no
FIRECRAWL_API_KEYis set.Changes
pyproject.tomlplugins/web/firecrawl/provider.pyWhat changed in provider.py
check_firecrawl_api_key()— always returnsTrue(SDK handles keyless fallback)_get_firecrawl_client()— when no credentials exist, falls back to v2 keyless client (v1 still requires API key, search/scrape are v2 methods)_KeylessFirecrawlClientcustom HTTP client (~70 lines)Why
_KeylessFirecrawlClientusing rawurllibbecause the old SDK (4.17.0) rejected no-key constructionapi_key=Nonefor v2 methods, making the custom HTTP client redundant