fix(memory): skip drift guard for add (append-only) action (#42874) - #52091
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2984: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
✅ Fixed issues (1):
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
Unchanged: 5914 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
alt-glitch
added
type/bug
The drift guard (introduced for #26045) correctly protects replace/remove from clobbering un-roundtrippable content, but it also fires on the add path. Since add only appends and never overwrites, the guard is unnecessary and causes false positives when prior add() calls in the same session shift the byte count of the on-disk file. Add skip_drift parameter to _reload_target() and pass True from add(). Replace/remove continue to use the drift guard unchanged. Salvaged from #42880 by @liuhao1024. Closes #42874
kshitijk4poor
force-pushed
the
salvage/42874-memory-drift-guard-add
branch
from
June 24, 2026 19:21
0873885 to
25e2312
Compare
kshitijk4poor
enabled auto-merge
June 24, 2026 19:25
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…-memory-drift-guard-add fix(memory): skip drift guard for add (append-only) action (NousResearch#42874)
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…-memory-drift-guard-add fix(memory): skip drift guard for add (append-only) action (NousResearch#42874)
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…-memory-drift-guard-add fix(memory): skip drift guard for add (append-only) action (NousResearch#42874)
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…-memory-drift-guard-add fix(memory): skip drift guard for add (append-only) action (NousResearch#42874)
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…-memory-drift-guard-add fix(memory): skip drift guard for add (append-only) action (NousResearch#42874)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory(action=add)no longer refuses legitimate appends when the on-disk MEMORY.md byte count differs from the in-memory base cache. The drift guard is now skipped for the append-onlyaddaction but remains active forreplace/removewhich flush full state.Changes
tools/memory_tool.py: addskip_driftkeyword parameter to_reload_target();add()passesskip_drift=Truewhilereplace()/remove()continue using the drift guard unchangedtests/tools/test_memory_tool.py: updatedtest_add_succeeds_despite_driftto verify add proceeds with driftValidation
Salvaged from #42880 by @liuhao1024.
Closes #42874