fix(browser): default non-finite Camofox vision config - #51978
Open
lin-hongkuan wants to merge 1 commit into
Open
lin-hongkuan wants to merge 1 commit into
lin-hongkuan wants to merge 1 commit into
Conversation
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for isolating the Camofox failure mode. The Camofox premise is confirmed on current main: tools/browser_camofox.py:894-915 converts auxiliary.vision values with float() and forwards them explicitly to call_llm.
Problems
- This is a shared-config bug class, but the patch covers only Camofox. The regular browser path still does unrestricted
float()conversion intools/browser_tool.py:4118-4121; image and video vision do the same intools/vision_tools.py:1236-1239and:1739-1742. Explicit timeouts are preserved byagent/auxiliary_client.py:6077and passed into the SDK request at:6529-6533.
Suggested changes
- Reuse one finite-value coercion helper across every
auxiliary.visionconfig-to-call boundary, preserving the video flow's 180-second floor. - Add regression coverage for the non-Camofox browser/image/video paths as well as this Camofox case.
Automated hermes-sweeper review.
| _vision_cfg = cfg_get(_cfg, "auxiliary", "vision", default={}) | ||
| _vision_timeout = float(_vision_cfg.get("timeout", 120)) | ||
| _vision_temperature = float(_vision_cfg.get("temperature", 0.1)) | ||
| _vision_timeout = _finite_float(_vision_cfg.get("timeout"), 120.0) |
Collaborator
There was a problem hiding this comment.
Please apply this finite-value coercion to the sibling auxiliary.vision parsers too: tools/browser_tool.py:4118-4121 and tools/vision_tools.py:1236-1239,1739-1742 still forward nan/inf as explicit LLM request values.
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infandnancall_llmTests
python -m pytest tests/tools/test_browser_camofox.py::TestCamofoxVisionConfig::test_camofox_vision_defaults_nonfinite_config -qNO_PROXY=localhost,127.0.0.1,::1 python -m pytest tests/tools/test_browser_camofox.py -qpython -m py_compile tools/browser_camofox.pypython scripts/check-windows-footguns.py --all