fix: add encoding='utf-8' to os.fdopen() and open() text-mode calls - #51766
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix: add encoding='utf-8' to os.fdopen() and open() text-mode calls#51766AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Add encoding='utf-8' to os.fdopen() and open() calls in text mode that omitted it. On Windows with non-UTF-8 locale, the default encoding is the system locale, causing UnicodeEncodeError on write. 4 files, 6 lines changed: - agent/nous_rate_guard.py: os.fdopen(fd, 'w') - agent/shell_hooks.py: os.fdopen(fd, 'w') - gateway/slash_commands.py: open(exit_code_path, 'w') - hermes_cli/config.py: 3x os.fdopen(fd, 'w', **write_kw)
alt-glitch
added
type/bug
Collaborator
Related: this is a superset of #51406 (which patches the two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
encoding='utf-8'toos.fdopen()andopen()calls in text mode that omitted it.Why
On Windows with non-UTF-8 locale, the default encoding is the system locale. Writing UTF-8 content without explicit encoding causes
UnicodeEncodeError.Complements PR #51748/#51752/#51761 (read_text/write_text) and #51406 (initial fdopen batch).
Changes (4 files, 6 lines)
agent/nous_rate_guard.pyos.fdopen(fd, 'w')→ add encodingagent/shell_hooks.pyos.fdopen(fd, 'w')→ add encodinggateway/slash_commands.pyopen(exit_code_path, 'w')→ add encodinghermes_cli/config.pyos.fdopen(fd, 'w', **write_kw)→ add encoding