Skip to content

fix(tui): preserve Ctrl+J newline in VTE terminals #51546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rvdavid-rbi wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix(tui): preserve Ctrl+J newline in VTE terminals #51546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5993e
fix(tui): preserve Ctrl+J newline in VTE terminals
rvdavid-rbi Jun 23, 2026
f877b5c
Merge branch 'NousResearch:main' into fix/tui-vte-ctrlj-newline
rvdavid-rbi Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui-tui/src/__tests__/textInputPassThrough.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ describe('shouldPreserveCtrlJNewline', () => {
).toBe(true)
})

it('keeps bare local POSIX LF-compatible prompts submitting on Ctrl+J', () => {
it('preserves Ctrl+J as newline in VTE terminals like GNOME Console/Terminal', () => {
expect(shouldPreserveCtrlJNewline({ TERM: 'xterm-256color', VTE_VERSION: '8400' })).toBe(true)
})

it('keeps bare local POSIX LF-compatible prompts submitting when no terminal fingerprint is available', () => {
expect(shouldPreserveCtrlJNewline({ TERM: 'xterm-256color' })).toBe(false)
})
})
Expand Down
4 changes: 4 additions & 0 deletions ui-tui/src/components/textInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ export function applyPrintableInsert(
export const shouldRouteMultiCharInputAsPaste = (text: string): boolean => text.includes('\n')

export function shouldPreserveCtrlJNewline(env: MinimalEnv = process.env): boolean {
if (env.VTE_VERSION) {
return true
}

if (env.WT_SESSION) {
return true
}
Expand Down