Skip to content

fix: broaden llama.cpp grammar error classifier to match newer builds #51527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gonzalofrancoceballos wants to merge 2 commits into from
+13 −1
Closed

fix: broaden llama.cpp grammar error classifier to match newer builds #51527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930d0f6
fix: broaden llama.cpp grammar error classifier to match newer builds
gonzalofrancoceballos Jun 23, 2026
e2a3df1
Merge remote-tracking branch 'origin/main' into fix/llama-cpp-grammar…
gonzalofrancoceballos Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agent/error_classifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,8 @@ def _result(reason: FailoverReason, **overrides) -> ClassifiedError:
if (
status_code == 400
and (
"error parsing grammar" in error_msg
"failed to parse grammar" in error_msg
or "error parsing grammar" in error_msg
or "json-schema-to-grammar" in error_msg
or (
"unable to generate parser" in error_msg
Expand Down
11 changes: 11 additions & 0 deletions tests/agent/test_error_classifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,17 @@ def test_llama_cpp_grammar_parse_error(self):
assert result.retryable is True
assert result.should_compress is False

def test_llama_cpp_failed_to_parse_grammar(self):
"""Newer llama.cpp builds return 'Failed to initialize samplers: failed to parse grammar'."""
e = MockAPIError(
"Failed to initialize samplers: failed to parse grammar",
status_code=400,
)
result = classify_api_error(e, provider="openai-compatible")
assert result.reason == FailoverReason.llama_cpp_grammar_pattern
assert result.retryable is True
assert result.should_compress is False

def test_llama_cpp_unable_to_generate_parser(self):
"""Older llama.cpp builds surface the error as 'unable to generate parser'."""
e = MockAPIError(
Expand Down