fix: align Fireworks model picker with setup flow - #51496
Closed
ft-ioxcs wants to merge 1 commit into
Closed
Conversation
Contributor
|
Fireworks AI support landed via PR #62593. This contribution was part of the Fireworks provider cluster credited in the salvage PR; thank you for the implementation and review work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Fireworks model-picker discrepancy between the standalone setup flow and the in-session
/modelpicker.The setup flow (
hermes setup model/hermes model) shows Fireworks models from the curated models.dev agentic list, with routers like:But the in-session
/modelpicker was going through the generic live provider catalog path first. For Fireworks, that live list could start with older/live-only model IDs such as:So the two model-selection surfaces appeared to offer different Fireworks model lists.
Change
For generic API-key providers that have no static curated list but are marked as models.dev-preferred, use the models.dev agentic list as the curated base before appending live-only API models.
This keeps Fireworks in the same top/order as the setup flow while still preserving live-only discovery after the curated agentic models.
The change is intentionally narrow:
Test plan
Confirmed the new regression test fails before the fix.
Then ran:
Result:
Ran the model-options parity guard too:
Result:
Compiled touched Python files:
Ran a live local comparison against the current Fireworks catalog path:
The
/modelpayload now starts with the same first 15 Fireworks entries shown by the setup flow, including the Fireworks routers from the screenshot.