fix: accept native Fireworks model IDs in doctor - #51479
Closed
ft-ioxcs wants to merge 1 commit into
Closed
Conversation
ft-ioxcs
force-pushed
the
fix/doctor-fireworks-model-slug
branch
from
June 23, 2026 18:12
fa348e0 to
e69dc2d
Compare
Contributor
|
Fireworks AI support landed via PR #62593. This contribution was part of the Fireworks provider cluster credited in the salvage PR; thank you for the implementation and review work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false-positive
hermes doctorwarning for native Fireworks model IDs.Fireworks model IDs can legitimately use the path-shaped form:
When
model.providerisfireworks, this is a native Fireworks model ID, not an OpenRouter-stylevendor/modelaggregator slug. The current doctor check treats any model string containing/as vendor-prefixed unless the provider is in the aggregator allowlist, so it incorrectly reports:Change
accounts/.../models/...shape.provider: fireworkswithdefault: accounts/fireworks/models/qwen3p7-plus.This avoids broadening Fireworks to accept every slash-containing model string. For example, the check can still warn if someone configures an actual two-part aggregator-style model slug on the native Fireworks provider.
Test plan
Confirmed the regression test fails before the fix with the exact false-positive warning.
Then ran:
Result:
Ran the related provider-slug doctor tests:
Result:
Ran the full doctor test module:
Result:
Compiled touched Python files:
Ran the live doctor command against the local config and confirmed the Fireworks warning no longer appears:
Output only showed the remaining unrelated issue count, with no Fireworks/vendor-prefix warning: