Conversation
Previously, skip_memory was hardcoded to True for all cron jobs.
This prevented users who want cron jobs to access conversation
memory (e.g., context-aware scheduled tasks) from opting in.
Now reads from config.yaml:
cron:
skip_memory: true # default, preserves existing behavior
The default remains True to avoid breaking existing setups, but
users can set it to false when their scheduled tasks benefit from
memory context.
Contributor
tonydwb
approved these changes
Jun 23, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
13-line change making skip_memory configurable via config.yaml. Default remains True (cron system prompts would corrupt user representations). Clean and backwards-compatible.
Reviewed by Hermes Agent
Collaborator
|
Thanks for addressing a real cron-memory limitation. The current implementation needs a safer scope before it can be considered. Problems
Suggested changes
Automated hermes-sweeper review. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
skip_memoryis hardcoded toTruefor all cron jobs incron/scheduler.py:2077:This prevents users who want scheduled tasks to benefit from conversation memory (e.g., context-aware daily briefings, memory-informed status reports) from opting in.
Change
Replace the hardcoded value with a config.yaml lookup:
Default remains
True— zero breaking change for existing setups. Users who want memory context in their cron jobs can set:Motivation
Some scheduled tasks (e.g., daily self-review, weekly retrospectives) benefit from knowing the user's accumulated preferences and context. The hardcoded
Trueforces all cron sessions into a memory-agnostic mode regardless of user intent.Test Plan
skip_memory=true(default) andskip_memory=falsewithout errors