fix(tools,agent): add explicit encoding to read_text/write_text - #51187
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix(tools,agent): add explicit encoding to read_text/write_text#51187AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Fix 7 files in tools/ and agent/ with unencoded read_text()/write_text() calls. Path.read_text() defaults to system locale (cp1252 on Windows). Ruff rule PLW1514.
alt-glitch
added
type/bug
tonydwb
approved these changes
Jun 23, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Clean encoding fix for read_text/write_text calls in tools/ and agent/ directories. Well-scoped (7 files, 21 additions), single concern, consistent pattern of adding encoding="utf-8" to file I/O operations. No security concerns, no test changes needed for this type of fix.
Reviewed by Hermes Agent
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
encoding="utf-8"to allread_text()/write_text()calls intools/andagent/directories.Path.read_text()defaults to system locale (cp1252 on Windows), causingUnicodeDecodeErrorfor UTF-8 content. Ruff rule PLW1514.Key files
tools/skills_hub.py(16 calls)tools/skills_sync.py,tools/checkpoint_manager.py,tools/managed_tool_gateway.py,tools/xai_http.pyagent/auxiliary_client.py,agent/curator.py,agent/copilot_acp_client.py,agent/skill_bundles.py,agent/shell_hooks.py,agent/curator_backup.pyTest plan
python3 -m py_compilepasses for all files